Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a note about minikube tunnel for Docker Desktop #44239

Merged
merged 1 commit into from
Dec 7, 2023

Conversation

adityasamant25
Copy link
Contributor

This PR tries to fix #40645

When using Docker Desktop as the container driver for minikube, a minikube tunnel is needed. This is because containers inside Docker Desktop are isolated from your host computer.
This is explained very well as a note in Using a Service to Expose Your App.

In this PR, I added the same section to Running Multiple Instances of Your App.

Suggestions and feedback are welcome.

Best Regards,
Aditya

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language labels Dec 6, 2023
@k8s-ci-robot k8s-ci-robot added sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Dec 6, 2023
Copy link

netlify bot commented Dec 6, 2023

Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit 65e1dc9
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/65706f9f46c35200089a5857
😎 Deploy Preview https://deploy-preview-44239--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@adityasamant25
Copy link
Contributor Author

/assign

@sftim
Copy link
Contributor

sftim commented Dec 6, 2023

/retitle Add a note about minikube tunnel for Docker Desktop

@k8s-ci-robot k8s-ci-robot changed the title Issue 40645 - Added a note about minikube tunnel for Docker Desktop Add a note about minikube tunnel for Docker Desktop Dec 6, 2023
Copy link
Contributor

@sftim sftim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

<p>The output looks like this:
<pre><b>http://127.0.0.1:51082<br>! Because you are using a Docker driver on darwin, the terminal needs to be open to run it.</b></pre></p>
<p>Then use the given URL to access the app:<br>
<code><b>curl 127.0.0.1:51082</b></code></p>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it obvious that this is an example?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sftim In my opinion, the section is worded in a way that makes it clear that this is an example.

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 6, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: dfb559aef10a8ee80d1c8bf7eb2f2e0db5548d90

Copy link
Contributor

@divya-mohan0209 divya-mohan0209 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this fix!
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: divya-mohan0209

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 7, 2023
@k8s-ci-robot k8s-ci-robot merged commit dc2c30e into kubernetes:main Dec 7, 2023
6 checks passed
@adityasamant25 adityasamant25 deleted the issue-40645 branch December 7, 2023 03:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Explain extra step for exposing Services locally on minikube
4 participants