-
Notifications
You must be signed in to change notification settings - Fork 14.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a note about minikube tunnel for Docker Desktop #44239
Conversation
✅ Pull request preview available for checkingBuilt without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
/assign |
/retitle Add a note about minikube tunnel for Docker Desktop |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
<p>The output looks like this: | ||
<pre><b>http://127.0.0.1:51082<br>! Because you are using a Docker driver on darwin, the terminal needs to be open to run it.</b></pre></p> | ||
<p>Then use the given URL to access the app:<br> | ||
<code><b>curl 127.0.0.1:51082</b></code></p> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it obvious that this is an example?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sftim In my opinion, the section is worded in a way that makes it clear that this is an example.
LGTM label has been added. Git tree hash: dfb559aef10a8ee80d1c8bf7eb2f2e0db5548d90
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for this fix!
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: divya-mohan0209 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This PR tries to fix #40645
When using Docker Desktop as the container driver for minikube, a minikube tunnel is needed. This is because containers inside Docker Desktop are isolated from your host computer.
This is explained very well as a note in Using a Service to Expose Your App.
In this PR, I added the same section to Running Multiple Instances of Your App.
Suggestions and feedback are welcome.
Best Regards,
Aditya