-
Notifications
You must be signed in to change notification settings - Fork 14.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a blog post about Kubernetes Networking Architecture #43914
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
✅ Pull request preview available for checking
To edit notification comments on pull requests, go to your Netlify site configuration. |
This is my first time uploading an article here, and it includes some images. However, I'm unsure about where to place these images. Can anyone offer some guidance? I would really appreciate it. |
All images are ready. Please have a review. Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@xPetersue Thanks for your contribution. Looks like the blog content is missing some front matter in markdown used by Hugo and there are some formatting issue.
Refer to the 'Submitting blog posts and case studies' page: https://kubernetes.io/docs/contribute/new-content/blogs-case-studies/ for guidance and feel free to seek assistance in the #sig-docs-blog channel on the Kubernetes Slack workspace.
/retitle [WIP] Add a blog post about Kubernetes Networking Architecture |
@dipesh-rawat Thanks for sharing this with me. It is really helpful. I have modified this blog's format as requested. Please have a review, hope it is ok this time. |
Could you help me proceed with this PR to accelerate its publication? If anyone could share the next steps in the process, I would greatly appreciate it. |
I will try to review the content of this PR during the weekend and provide advice. Initially I think that the sections:
Can be omitted as this is the Kubernetes blog already, people should be familiar with those topics. |
@salaboy Thanks for your suggestion. I have removed the four parts as you mentioned above. Please check, and thanks for investing time to review this blog. |
@xPetersue my other recommendation would be to add a short description of the blog post here in the initial comment but remove all the content from here, and just leave that in the file that is changed. The PR content will not be evaluated based on what we see on the comments here, but only based on what is on the file that you are submitting as part of this PR. So for example if you look at the file, the sections that you mention that you have removed are still there: https://github.com/kubernetes/website/pull/43914/files#diff-4752d92c319d8fff5838e250ba4a24e56593b25f3aa5d6611fef0bc76d15b54eR4 |
@salaboy I have modified everything you suggested here. Please check. Thanks for your contribution. Really appreciate it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this insightful article @xPetersue!
I've added some initial reviews to move the progress on this PR
Here are some observation:
-
We need to correct the directory structure,
We follow the structure
content/en/blog/_posts/<blog_date>-<blog_name>/index.md
'index.md' should contain this article, and the images can be a part of this same directory -
The images are generally in .svg format
-
I've addressed some conventions in the suggestions
I'll be happy to complete the review post these amendments
@Gauravpadam Thank you very much for your assistance. I have resolved all of your comments. Please take a moment to review the changes. I truly appreciate your help. We are nearly there. Cheers! |
This PR is marked as a work in progress. Would you like it reviewed @xPetersue? /hold |
@sftim Yes, please mark it reviewed. Thanks! |
You can make that change yourself @xPetersue - I'll do that now, anyway /retitle Add a blog post about Kubernetes Networking Architecture |
@xPetersue I had a read of your blog post and found it interesting, and very comprehensive. I would go as far as to say there could be the makings of 3 or more different posts in this As I was reading through the first section on different interface types, I started wondering how all of these are relevant to kubernetes. Maybe this section could be slimmed down to have info on the most relevant interface type for kubernetes? The gifs for showing pod to pod comms etc.. were useful in showing the layers traffic goes through. To keep the post on point, I'd even go as far as removing these sections (definitely useful in the right context though)
In general, if the most relevant things to kubernetes networking are kept, with a loose goal of the post to show how kube networking works from the ground up, this would be excellent. I do have a few other pieces of feedback, but they are more about the style of writing than the content.
|
That's a good suggestion. @xPetersue we can help you split this up if that matches what you would like to do. |
@sftim I'm okay with splitting up this blog. However, I can't agree with removing the content. I wrote these sections because they are closely related to each other. As for the ending part, you may consider it impractical, but many people have their own Hamlet. I recommend keeping them. Thank you. |
amend as suggested
amend as suggested
@david-martin Thank you for taking the time to read my blog and provide valuable comments. Here are the responses to your three categories of feedback.
I truly appreciate your help. Thanks once more! |
@xPetersue, this PR could become the basis of a series of articles that would be really useful. However, we'd want to align it more with our docs style guide, and we'd want to ensure there wasn't anything in the article text that is outright misleading. Are you on the Kubernetes Slack workspace? I'd like to facilitate collaboration on this, with you and some people associated with the blog editorial side working together to produce a series of articles that you're happy to put your name to. I asked about Slack because I think this will take some time (weeks on a calendar; more than two hours of actual collaboration). If you have the appetite to work on this further, please say Hi in #sig-docs-blog on the Kubernetes Slack workspace (I'm @sftim there). You can visit https://slack.k8s.io/ for an invitation. |
@sftim Thanks. I have contacted you via Kubernetes Slack. Let me know what else I need to you. |
We discussed this on a Zoom call. A large portion of this article has already been published at https://cloudnativenow.com/topics/cloudnativenetworking/understanding-kubernetes-networking-architecture/ We require a copyright licence - the CNCF CLA - for contributions, and we cannot accept articles that have been published elsewhere (or where substantial portions have been). There are several obstacles to publication
Right now, the principal obstacle is that you have published elsewhere. We could only publish another article that was clearly different from what you've proposed. Thank you for your enthusiasm. We - Kubernetes - could benefit from a good explanation of the topic you're proposed, but this work as it stands cannot move forwards to publication. |
/hold We will close this PR soon. |
@sftim Regarding your three comments, here are my proposed solutions:
In summary, I am committed to adhering to Kubernetes.io's rules and regulations while sharing my knowledge with fellow professionals, making their understanding of Kubernetes networking architecture smoother and less challenging. I am determined to make the most of the past two months of work and contributions. I kindly request that you refrain from closing this PR too hastily, and I greatly appreciate your assistance in this endeavour. |
/close |
@sftim: Closed this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Hi! I have been planning to elaborate on the Kubernetes Networking Architecture for ages. As far as I know, nobody has explained this topic clearly with both a good command of networking and Linux. Here, with my 10 years of DevOps work experience and double CCIE certification in the fields of networking and cybersecurity, I have put in half a year's worth of hard work to provide a detailed explanation. You can find the entire article at the following link.
https://github.com/kubernetes/website/pull/43914/files
Feel free to leave comments and contribute to the PR (Pull Request) process. I need all of your help for this initial endeavour. Cheers!