-
Notifications
You must be signed in to change notification settings - Fork 14.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hugo improvements #29504
Hugo improvements #29504
Conversation
Old build (current published one on main):
This build:
|
✔️ Deploy Preview for kubernetes-io-main-staging ready! 🔨 Explore the source changes: e01f70d 🔍 Inspect the deploy log: https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/6122af1366766a0007b04f9f 😎 Browse the preview: https://deploy-preview-29504--kubernetes-io-main-staging.netlify.app |
Wow, that’s amazing! 🤩 Thanks for finding a solution, @jimangel! /lgtm |
LGTM label has been added. Git tree hash: d40d479abb78d6ce6d24836d0a1f30e30c2ad2df
|
/approve in case further testing is wanted |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sftim The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
anyone: feel free to unhold |
Let it rip! 🚀 |
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
This PR was created to address the performance of Hugo. I would love to have a few folks check full functionality.
By setting
params.ui.sidebar_cache_limit
to 1, the build time went from 1m30s to 15s locally and 5m45s to 45s in Netlify!!! (details)While I was making tweaks, I wanted to remove the
WARNING: calling IsSet with unsupported type "invalid" (<nil>) will always return false.
Fixed via docsy, so I upgraded the module in the second commit following my old instructions.Lastly, I tested this on the latest build of Hugo and updated
netlify.toml
to match.Potentially fixes: #29429
Site preview: https://deploy-preview-29504--kubernetes-io-main-staging.netlify.app