Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ttlafterfinish to beta #26738

Merged
merged 1 commit into from
Feb 27, 2021
Merged

ttlafterfinish to beta #26738

merged 1 commit into from
Feb 27, 2021

Conversation

ahg-g
Copy link
Member

@ahg-g ahg-g commented Feb 26, 2021

@k8s-ci-robot k8s-ci-robot added this to the 1.21 milestone Feb 26, 2021
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Feb 26, 2021
@k8sio-netlify-preview-bot
Copy link
Collaborator

Deploy preview for kubernetes-io-vnext-staging processing.

Building with commit 05e0328

https://app.netlify.com/sites/kubernetes-io-vnext-staging/deploys/603951d13f46420008f59a9f

@k8s-ci-robot k8s-ci-robot added the language/en Issues or PRs related to English language label Feb 26, 2021
@k8s-ci-robot k8s-ci-robot added sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Feb 26, 2021
@ahg-g
Copy link
Member Author

ahg-g commented Feb 26, 2021

/assign @janetkuo

@ahg-g
Copy link
Member Author

ahg-g commented Feb 26, 2021

/sig apps

@k8s-ci-robot k8s-ci-robot added the sig/apps Categorizes an issue or PR as relevant to SIG Apps. label Feb 26, 2021
@janetkuo
Copy link
Member

/lgtm

@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 42b45fe0313c6a89fab2cb45940c43a59ccf0d0e

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 26, 2021
@sftim
Copy link
Contributor

sftim commented Feb 27, 2021

/sig apps


The TTL controller provides a TTL (time to live) mechanism to limit the lifetime of resource
objects that have finished execution. TTL controller only handles
{{< glossary_tooltip text="Jobs" term_id="job" >}} for now,
and may be expanded to handle other resources that will finish execution,
such as Pods and custom resources.

Alpha Disclaimer: this feature is currently alpha, and can be enabled with both kube-apiserver and kube-controller-manager
This feature is currently beta and enabled by default, and can be disabled via
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nits (these don't block a merge):

Suggested change
This feature is currently beta and enabled by default, and can be disabled via
This feature is beta and enabled by default. You can disable it using the

@sftim
Copy link
Contributor

sftim commented Feb 27, 2021

Given that kubernetes/kubernetes#98678 is merged:
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: janetkuo, sftim

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 27, 2021
@k8s-ci-robot k8s-ci-robot merged commit 7359ee7 into kubernetes:dev-1.21 Feb 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/apps Categorizes an issue or PR as relevant to SIG Apps. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants