Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update ServiceAccountIssuerDiscovery docs for GA #26660

Merged
merged 1 commit into from
Feb 25, 2021
Merged

Update ServiceAccountIssuerDiscovery docs for GA #26660

merged 1 commit into from
Feb 25, 2021

Conversation

mtaufen
Copy link
Contributor

@mtaufen mtaufen commented Feb 21, 2021

Updates the SAID feature docs now that the feature is GA in 1.21.

See: kubernetes/enhancements#1393

@k8s-ci-robot k8s-ci-robot added this to the 1.21 milestone Feb 21, 2021
@k8sio-netlify-preview-bot
Copy link
Collaborator

k8sio-netlify-preview-bot commented Feb 21, 2021 •
edited
Loading

Deploy preview for kubernetes-io-vnext-staging processing.

Building with commit a0d5091

https://app.netlify.com/sites/kubernetes-io-vnext-staging/deploys/6034193e7ab3cf00080c0ef3

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Feb 21, 2021
@mtaufen
Copy link
Contributor Author

mtaufen commented Feb 21, 2021

/assign @sftim

@k8s-ci-robot k8s-ci-robot added language/en Issues or PRs related to English language sig/docs Categorizes an issue or PR as relevant to SIG Docs. labels Feb 21, 2021
@mtaufen mtaufen mentioned this pull request Feb 21, 2021
Closed
12 tasks
sftim
sftim previously requested changes Feb 22, 2021
View reviewed changes
Copy link
Contributor

@sftim sftim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mtaufen thanks

I think it needs one correction - see inline feedback.

content/en/docs/tasks/configure-pod-container/configure-service-account.md Outdated Show resolved Hide resolved
@liggitt
Copy link
Member

liggitt commented Feb 22, 2021

lgtm after the for_k8s_version comment is addressed

@reylejano
Copy link
Member

reylejano commented Feb 22, 2021 •
edited
Loading

/milestone 1.21
/assign @mvortizr
/sig auth

@k8s-ci-robot
Copy link
Contributor

@reylejano: The provided milestone is not valid for this repository. Milestones in this repository: [1.18-ja.1, 1.18-ja.2, 1.21, dev-1.20-ko.3, dev-1.20-ko.4, dev-1.20-ko.5]

Use /milestone clear to clear the milestone.

In response to this:

/milestone 1.20
/assign @mvortizr
/sig auth

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the sig/auth Categorizes an issue or PR as relevant to SIG Auth. label Feb 22, 2021
@mtaufen mtaufen requested a review from sftim February 22, 2021 20:51
@mtaufen
Copy link
Contributor Author

mtaufen commented Feb 22, 2021

Updated.

@sftim sftim dismissed their stale review February 23, 2021 09:30

Superseded

@liggitt
Copy link
Member

liggitt commented Feb 23, 2021

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 23, 2021
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: fdc642e7c27130d3c9ccaf697341d3202ec0016d

irvifa
irvifa reviewed Feb 25, 2021
View reviewed changes
Copy link
Member

@irvifa irvifa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: irvifa

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 25, 2021
@k8s-ci-robot k8s-ci-robot merged commit b709953 into kubernetes:dev-1.21 Feb 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@irvifa irvifa irvifa left review comments

@liggitt liggitt Awaiting requested review from liggitt

@sftim sftim Awaiting requested review from sftim

Assignees

@liggitt liggitt

@sftim sftim

@mvortizr mvortizr

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/auth Categorizes an issue or PR as relevant to SIG Auth. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
1.21
Development

Successfully merging this pull request may close these issues.
8 participants
@mtaufen @k8sio-netlify-preview-bot @liggitt @reylejano @k8s-ci-robot @irvifa @sftim @mvortizr