Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update namespaces.md #25678

Merged
merged 1 commit into from
Dec 17, 2020
Merged

Update namespaces.md #25678

merged 1 commit into from
Dec 17, 2020

Conversation

guzj11
Copy link
Contributor

@guzj11 guzj11 commented Dec 17, 2020

update the unnumbered format

@guzj11
Update namespaces.md
fcef54f 
update the unnumbered format
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language labels Dec 17, 2020
@k8s-ci-robot k8s-ci-robot added sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Dec 17, 2020
@tengqm
Copy link
Contributor

tengqm commented Dec 17, 2020

/lgtm
Thanks.

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 17, 2020
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 545addf4a5b80e387f29807834fd5900294b8d7c

@netlify
Copy link

netlify bot commented Dec 17, 2020

✔️ Deploy preview for kubernetes-io-master-staging ready!

🔨 Explore the source changes: fcef54f

🔍 Inspect the deploy logs: https://app.netlify.com/sites/kubernetes-io-master-staging/deploys/5fdb10a13b8cfe0007b5f185

😎 Browse the preview: https://deploy-preview-25678--kubernetes-io-master-staging.netlify.app

@guzj11
Copy link
Contributor Author

guzj11 commented Dec 17, 2020

/lgtm
Thanks.

can we merge this commit?

sftim
sftim reviewed Dec 17, 2020
View reviewed changes
Copy link
Contributor

@sftim sftim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sftim

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 17, 2020
@k8s-ci-robot k8s-ci-robot merged commit d338c04 into kubernetes:master Dec 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sftim sftim sftim left review comments

@derekwaynecarr derekwaynecarr Awaiting requested review from derekwaynecarr

@onlydole onlydole Awaiting requested review from onlydole

Assignees

@tengqm tengqm

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@guzj11 @tengqm @k8s-ci-robot @sftim