Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update declarative-config.md #25603

Merged
merged 1 commit into from
Dec 17, 2020
Merged

Update declarative-config.md #25603

merged 1 commit into from
Dec 17, 2020

Conversation

guzj11
Copy link
Contributor

@guzj11 guzj11 commented Dec 14, 2020

add the translation of step 4

@guzj11
Update declarative-config.md
4547d62 
add the translation of step 4
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/zh Issues or PRs related to Chinese language labels Dec 14, 2020
@k8s-ci-robot k8s-ci-robot added sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Dec 14, 2020
@netlify
Copy link

netlify bot commented Dec 14, 2020

Deploy preview for kubernetes-io-master-staging ready!

Built with commit 4547d62

https://deploy-preview-25603--kubernetes-io-master-staging.netlify.app

@tengqm
Copy link
Contributor

tengqm commented Dec 14, 2020

/approve

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 14, 2020
markthink
markthink reviewed Dec 17, 2020
View reviewed changes
Copy link

@markthink markthink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 17, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: markthink, tengqm

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: c0eaaf4ed3130de0c8fddf94a5c0ff0a81a7ce48

@k8s-ci-robot k8s-ci-robot merged commit 255fe9e into kubernetes:master Dec 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@markthink markthink markthink left review comments

@pigletfly pigletfly Awaiting requested review from pigletfly

@tengqm tengqm Awaiting requested review from tengqm

Assignees

@markthink markthink

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/zh Issues or PRs related to Chinese language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@guzj11 @tengqm @k8s-ci-robot @markthink