Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update node-conformance.md #25423

Merged
merged 1 commit into from
Dec 17, 2020
Merged

Update node-conformance.md #25423

merged 1 commit into from
Dec 17, 2020

Conversation

jiaj12
Copy link
Contributor

@jiaj12 jiaj12 commented Dec 6, 2020

update zh doc to match en master branch

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/zh Issues or PRs related to Chinese language labels Dec 6, 2020
@k8s-ci-robot k8s-ci-robot added sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Dec 6, 2020
@netlify
Copy link

netlify bot commented Dec 6, 2020 •
edited
Loading

✔️ Deploy preview for kubernetes-io-master-staging ready!

🔨 Explore the source changes: 980d7f1

🔍 Inspect the deploy logs: https://app.netlify.com/sites/kubernetes-io-master-staging/deploys/5fdab18ec6e777000752eb5b

😎 Browse the preview: https://deploy-preview-25423--kubernetes-io-master-staging.netlify.app

@tengqm
Copy link
Contributor

tengqm commented Dec 7, 2020

Preview: https://deploy-preview-25423--kubernetes-io-master-staging.netlify.app/zh/docs/setup/best-practices/node-conformance/

@jiaj12
Copy link
Contributor Author

jiaj12 commented Dec 12, 2020

squashed

@jiaj12 jiaj12 requested a review from tengqm December 15, 2020 01:04
@jiaj12
Copy link
Contributor Author

jiaj12 commented Dec 17, 2020

squashed

@tengqm
Copy link
Contributor

tengqm commented Dec 17, 2020

/approve

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 17, 2020
markthink
markthink reviewed Dec 17, 2020
View reviewed changes
Copy link

@markthink markthink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 17, 2020
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 17bee024408986c2ee7cefca820ff170e7f63ae6

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: markthink, tengqm

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 37f46ed into kubernetes:master Dec 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tengqm tengqm tengqm left review comments

@markthink markthink markthink left review comments

@Random-Liu Random-Liu Awaiting requested review from Random-Liu

Assignees

@markthink markthink

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/zh Issues or PRs related to Chinese language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jiaj12 @tengqm @k8s-ci-robot @markthink