-
Notifications
You must be signed in to change notification settings - Fork 14.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create a "releases" page #22736
Create a "releases" page #22736
Conversation
Deploy preview for kubernetes-io-master-staging ready! Built with commit 3b76dd2 https://deploy-preview-22736--kubernetes-io-master-staging.netlify.app |
1eb4d31
to
80f58f0
Compare
/sig release |
This is a great start @sftim, thanks for working on this! General comments / opinions:
Not sure if we could leverage something like https://github.com/kubernetes/release/tree/master/cmd/schedule-builder (creates: https://github.com/kubernetes/sig-release/blob/master/releases/schedule.yaml) I love the use of data templates in this case! |
👍 Not sure how to do that, but it sounds possible. |
I wouldn't use a shortcode for that, but yes that sounds achievable. |
dcfa3d7
to
53a7056
Compare
We already have a deprecation message, so I'm assuming that the release page for a previous release would say something like
|
Hello, all. |
I suspect it's a bit close to the v1.19 release to get this finished. I'd be happy to get this over the line for v1.19 though! |
53a7056
to
9dda45e
Compare
For the release process I have in mind, we might (manually? semi-automatically?) configure documentation for previous releases to automatically redirect some of the release pages to the live site. As a sort of belt-and-braces approach, I've also made Hugo render a link to the current docs in place of showing the release notes list. What else needs to change before this can go live? I'm keen to hear from SIG Release folks. |
9dda45e
to
6a2a7e1
Compare
Relevant to issue #21063 |
6a2a7e1
to
7ff77f1
Compare
Can this be reverse chronological sort for freshest on top? |
This one should be reverse chronological also. And it might should be trimmed to have just the most recent visible by default for simplicity, plus some collapsabled-by-default UI element to click to "view no longer supported releases". Similar for the overall list of the 1.0..1.Y releases. Show the current 3 or 4 getting patch support and click to "view no longer supported releases" which are default hidden behind a UI element. These lists will be growing eternally. We want to make finding the info easier, but also focus eyes on the most relevant ones. Perhaps by doing this collapsing it's then not necessary to pop off to its own page all the 1.19.Z's and a page for all the 1.18.Z's, etc.? |
@tpepper can you clarify if that recent feedback is “we must have these features before we can have a releases page” or “here are some extra features to prioritize once we do”? I'd like to get something acceptable deployed, and then iterate. |
@sftim reverse chronological order I'd consider a must, but am also open to others' opinions on the UX. Everything else definitely deploy and iterate. |
When I drafted this, there was no v1.19 |
aceef5b
to
c9f6ef8
Compare
On this website, page titles are in title case. |
3ad9b2b
to
22fb3d0
Compare
Hello @sftim . More feedback: The current "Getting Started -> Kubernetes Releases" section lists only the current release note information (v1.19). The proposed changes offer the list of release notes and a "Downloads" page. I could imagine a "Release Notes" page that includes the list of release notes instead of a separate To maintain this list of release notes, the script needs to run after the release (or at the end of the release)? |
Good point. Maybe Downloads could go in place of the Community link on the site navigation (and then we find a different way to signpost readers to https://k8s.dev/) Overall, this is going to be a long term piece of work I suspect. I might not have time to work more on this until mid-November. I hope to draw in more help, that'd be ideal. |
22fb3d0
to
6e961fb
Compare
@justaugustus (following up on a conversation from earlier, sort of) if the release metadata were already published in JSON, I could tell Hugo to render pages based on fetching it. This approach is OK for a proof-of-concept but it's not really good enough to merge. |
@jimangel is there any simple change I can make here to make this a better prototype? (in other words - there's loads of improvements to potentially make, are there any that stand out as things to fix first) |
@sftim I've been chatting with @justaugustus after his email and we're working on a plan that aligns both SIG Docs and SIG Release. More to come, sorry for the long tail on this. Hopefully coming to a final direction soon! |
Issues go stale after 90d of inactivity. If this issue is safe to close now please do so with Send feedback to sig-contributor-experience at kubernetes/community. |
6e961fb
to
3b76dd2
Compare
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@sftim: PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Closing this in favor of #27929 |
/close |
@justaugustus: Closed this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
To make this work the release process needs to change: after the release artifacts are available and GitHub is updated, run
scripts/update_releases.sh
and commit the changes todata/releases/dates.json
.At a stretch you can say that this fixes #20293
although there is clearly room for improvement.