Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unclear statement about kubelet "Log rotation" on "Logging Architecture" #44550

Closed
Tracked by #44609
able8 opened this issue Dec 28, 2023 · 10 comments · Fixed by #45194
Closed
Tracked by #44609

Unclear statement about kubelet "Log rotation" on "Logging Architecture" #44550

able8 opened this issue Dec 28, 2023 · 10 comments · Fixed by #45194
Assignees
Labels
language/en Issues or PRs related to English language priority/backlog Higher priority than priority/awaiting-more-evidence. sig/docs Categorizes an issue or PR as relevant to SIG Docs. sig/node Categorizes an issue or PR as relevant to SIG Node. triage/accepted Indicates an issue or PR is ready to be actively worked on.

Comments

@able8
Copy link
Contributor

able8 commented Dec 28, 2023

On https://kubernetes.io/docs/concepts/cluster-administration/logging/#log-rotation

Since the "Log rotation" feature is stable and enabled by default from v1.21,
we may remove the words "You can configure" and "If you configure rotation".

Log rotation
FEATURE STATE: Kubernetes v1.21 [stable]
You can configure the kubelet to rotate logs automatically.
If you configure rotation, the kubelet is responsible for rotating container logs and managing the logging directory structure.

BTW, it would be good to mention the following default values, refer to https://kubernetes.io/docs/reference/command-line-tools-reference/kubelet/

--container-log-max-size string     Default: 10Mi
--container-log-max-files int32     Default: 5

You can configure two kubelet configuration settings, containerLogMaxSize and containerLogMaxFiles, using the kubelet configuration file.

@k8s-ci-robot k8s-ci-robot added the needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. label Dec 28, 2023
@thisisharrsh
Copy link
Contributor

/language en
/sig docs

@k8s-ci-robot k8s-ci-robot added language/en Issues or PRs related to English language sig/docs Categorizes an issue or PR as relevant to SIG Docs. labels Dec 28, 2023
@sftim
Copy link
Contributor

sftim commented Dec 28, 2023

/sig node

@k8s-ci-robot k8s-ci-robot added the sig/node Categorizes an issue or PR as relevant to SIG Node. label Dec 28, 2023
@haripriya9647
Copy link
Contributor

/assign

@aj11anuj
Copy link
Member

aj11anuj commented Feb 2, 2024

/kind bug
Any updates? @haripriya9647

@k8s-ci-robot k8s-ci-robot added the kind/bug Categorizes issue or PR as related to a bug. label Feb 2, 2024
@haripriya9647 haripriya9647 removed their assignment Feb 2, 2024
@kannon92
Copy link
Contributor

/remove-kind bug
/kind feature

@k8s-ci-robot k8s-ci-robot added kind/feature Categorizes issue or PR as related to a new feature. and removed kind/bug Categorizes issue or PR as related to a bug. labels Feb 14, 2024
@kannon92
Copy link
Contributor

/remove-kind feature
/kind docs

@k8s-ci-robot k8s-ci-robot removed the kind/feature Categorizes issue or PR as related to a new feature. label Feb 14, 2024
@k8s-ci-robot
Copy link
Contributor

@kannon92: The label(s) kind/docs cannot be applied, because the repository doesn't have them.

In response to this:

/remove-kind feature
/kind docs

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@kannon92
Copy link
Contributor

kannon92 commented Feb 14, 2024

I think mentioning the defaults for kubelet configuration would be useful.

/triage accepted

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Feb 14, 2024
@kannon92
Copy link
Contributor

/priority backlog

@k8s-ci-robot k8s-ci-robot added the priority/backlog Higher priority than priority/awaiting-more-evidence. label Feb 14, 2024
@able8
Copy link
Contributor Author

able8 commented Feb 18, 2024

/assign

@kannon92 kannon92 moved this to Done in SIG Node Bugs Jul 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
language/en Issues or PRs related to English language priority/backlog Higher priority than priority/awaiting-more-evidence. sig/docs Categorizes an issue or PR as relevant to SIG Docs. sig/node Categorizes an issue or PR as relevant to SIG Node. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

7 participants