Add tests for 1.17 on kubernetes master

[ggriffiths]

Signed-off-by: Grant Griffiths [email protected]

[k8s-ci-robot]

Welcome @ggriffiths!

It looks like this is your first PR to kubernetes/test-infra 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/test-infra has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

[k8s-ci-robot]

Hi @ggriffiths. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[pohly]

It looks like you updated and ran the script, but then only committed one of the new jobs. The dind_image variable in the script also needs to be updated, otherwise we downgrade the images in the existing jobs.

Please add this change, then re-run the script and commit all of the changes:

diff --git a/config/jobs/kubernetes-csi/gen-jobs.sh b/config/jobs/kubernetes-csi/gen-jobs.sh
index 2328891c9..72c3b9560 100755
--- a/config/jobs/kubernetes-csi/gen-jobs.sh
+++ b/config/jobs/kubernetes-csi/gen-jobs.sh
@@ -25,7 +25,7 @@ latest_stable_k8s_version="1.16.2"
 latest_stable_k8s_minor_version="1.16"
 
 # We need this image because it has Docker in Docker and go.
-dind_image="gcr.io/k8s-testimages/kubekins-e2e:v20191031-df9cbb4-master"
+dind_image="gcr.io/k8s-testimages/kubekins-e2e:v20191112-9f04410-master"
 
 # All kubernetes-csi repos which are part of the hostpath driver example.
 # For these repos we generate the full test matrix. For each entry here

[ggriffiths]

Ah I see. I didn't run the script originally - just copied another "k8s X on master" test and updated it for 1.17.

Just updated and ran it, and committed the changes. Thanks!

[pohly]

/lgtm

[pohly]

/assign @msau42
For approval.

[msau42]

There seems to be the deployment variable missing from this config. Or is not setting it supposed to imply "latest" deployment? cc @pohly

[pohly]

Not setting CSI_PROW_DEPLOYMENT is okay.

The following code will then fall back to the deployment for the selected Kubernetes version or, if that isn't found, use the "kubernetes-latest" deployment:

https://github.com/kubernetes-csi/csi-release-tools/blob/4fcafece595651bea0354e310874f661ed81813f/prow.sh#L583-L609

[msau42]

/ok-to-test
/approve

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ggriffiths, msau42

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• config/jobs/kubernetes-csi/OWNERS [msau42]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[k8s-ci-robot]

@ggriffiths: Updated the job-config configmap in namespace default at cluster default using the following files:

• key csi-driver-host-path-config.yaml using file config/jobs/kubernetes-csi/csi-driver-host-path/csi-driver-host-path-config.yaml
• key external-attacher-config.yaml using file config/jobs/kubernetes-csi/external-attacher/external-attacher-config.yaml
• key external-provisioner-config.yaml using file config/jobs/kubernetes-csi/external-provisioner/external-provisioner-config.yaml
• key external-resizer-config.yaml using file config/jobs/kubernetes-csi/external-resizer/external-resizer-config.yaml
• key external-snapshotter-config.yaml using file config/jobs/kubernetes-csi/external-snapshotter/external-snapshotter-config.yaml
• key livenessprobe-config.yaml using file config/jobs/kubernetes-csi/livenessprobe/livenessprobe-config.yaml
• key node-driver-registrar-config.yaml using file config/jobs/kubernetes-csi/node-driver-registrar/node-driver-registrar-config.yaml

In response to this:

Signed-off-by: Grant Griffiths [email protected]

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.