Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch production bucket #3749

Merged
merged 1 commit into from
Sep 10, 2024
Merged

Switch production bucket #3749

merged 1 commit into from
Sep 10, 2024

Conversation

ameukam
Copy link
Member

@ameukam ameukam commented Sep 9, 2024

What type of PR is this?

/kind feature

What this PR does / why we need it:

Use a community-bucket for Kubernetes releases

Which issue(s) this PR fixes:

Part of:

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Use a community-owned bucket for releases

@ameukam
Switch production bucket
411515c 
Part of:
 - kubernetes#3729

Use a community-bucket for Kubernetes releases
@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/feature Categorizes issue or PR as related to a new feature. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-priority area/release-eng Issues or PRs related to the Release Engineering subproject labels Sep 9, 2024
@k8s-ci-robot k8s-ci-robot added the sig/release Categorizes an issue or PR as relevant to SIG Release. label Sep 9, 2024
@ameukam
Copy link
Member Author

ameukam commented Sep 9, 2024

cc @kubernetes/release-engineering
/hold

@k8s-ci-robot k8s-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Sep 9, 2024
cpanato
cpanato reviewed Sep 10, 2024
View reviewed changes
pkg/release/release.go
@@ -103,7 +103,8 @@ const (
TestBucket = "kubernetes-release-gcb"

// ProductionBucket is the default bucket for Kubernetes releases.
ProductionBucket = "kubernetes-release"
// Owned by SIG k8s Infra: https://git.k8s.io/community/sig-k8s-infra
ProductionBucket = "767373bbdcb8270361b96548387bf2a9ad0d48758c35"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

where can we check this value?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cpanato https://github.com/kubernetes/k8s.io/blob/5a417fe27eae5891761f8f636857fcb1e1baa173/infra/gcp/terraform/k8s-infra-releases-prod/main.tf#L38

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it possible for us to view the contents of the bucket using a short URL?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah. I will have a PR against https://git.k8s.io/k8s.io that will allow release managers to view the content of the bucket.

saschagrunert
saschagrunert reviewed Sep 10, 2024
View reviewed changes
Copy link
Member

@saschagrunert saschagrunert left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ameukam thank you for the PR, can we verify that it works? For example using:

export TOOL_ORG=… && export TOOL_REF=… && go run ./cmd/krel stage

@ameukam
Copy link
Member Author

ameukam commented Sep 10, 2024

@ameukam thank you for the PR, can we verify that it works? For example using:

export TOOL_ORG=… && export TOOL_REF=… && go run ./cmd/krel stage

@saschagrunert https://console.cloud.google.com/cloud-build/builds;region=global/e0a3ad16-5f05-49e0-b867-3ba15712a5ed;tab=detail?project=kubernetes-release-test

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 10, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ameukam, saschagrunert

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 10, 2024
@ameukam
Copy link
Member Author

ameukam commented Sep 10, 2024

FYI, I didn't find a way to validate this with the no-mock steps. I intend to use the release of 1.28.14 to validate this.

@saschagrunert Do we need to cut another release of the repo ?

@saschagrunert
Copy link
Member

@saschagrunert Do we need to cut another release of the repo ?

Yeah we can do that after this PR lands.

@ameukam
Copy link
Member Author

ameukam commented Sep 10, 2024

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 10, 2024
@k8s-ci-robot k8s-ci-robot merged commit 23a6a81 into kubernetes:master Sep 10, 2024
11 checks passed
cpanato
cpanato reviewed Sep 10, 2024
View reviewed changes
Copy link
Member

@cpanato cpanato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

late lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cpanato cpanato cpanato left review comments

@saschagrunert saschagrunert saschagrunert approved these changes

Assignees

@saschagrunert saschagrunert

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/release-eng Issues or PRs related to the Release Engineering subproject cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/release Categorizes an issue or PR as relevant to SIG Release. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ameukam @k8s-ci-robot @saschagrunert @cpanato