Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

move to community staging bucket #928

Merged
merged 1 commit into from
Jul 18, 2024
Merged

move to community staging bucket #928

merged 1 commit into from
Jul 18, 2024

Conversation

BenTheElder
Copy link
Member

part of #920

following kubernetes/k8s.io#7007

we also need to make sure jobs are on k8s-infra-prow-builds, will go check in test-infra

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jul 17, 2024
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jul 17, 2024
@BenTheElder
Copy link
Member Author

/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 17, 2024
@BenTheElder BenTheElder mentioned this pull request Jul 17, 2024
Merged
@BenTheElder
Copy link
Member Author

need kubernetes/test-infra#33015

@hakman
Copy link
Member

hakman commented Jul 18, 2024

/test all

@hakman
Copy link
Member

hakman commented Jul 18, 2024

/lgtm
/cc @wangzhen127 @vteratipally

@k8s-ci-robot k8s-ci-robot requested a review from wangzhen127 July 18, 2024 03:56
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 18, 2024
@hakman
Copy link
Member

hakman commented Jul 18, 2024

All green now. Thanks @BenTheElder! 😄

@BenTheElder
Copy link
Member Author

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 18, 2024
@wangzhen127
Copy link
Member

/lgtm

Thanks, @BenTheElder!

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: BenTheElder, hakman, wangzhen127

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 18, 2024
@k8s-ci-robot k8s-ci-robot merged commit 369020d into kubernetes:master Jul 18, 2024
11 checks passed
@BenTheElder BenTheElder deleted the community-bucket branch July 18, 2024 16:13
@BenTheElder BenTheElder mentioned this pull request Jul 18, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sjenning sjenning Awaiting requested review from sjenning

@vteratipally vteratipally Awaiting requested review from vteratipally

@wangzhen127 wangzhen127 Awaiting requested review from wangzhen127

Assignees

@wangzhen127 wangzhen127

@hakman hakman

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@BenTheElder @hakman @wangzhen127 @k8s-ci-robot