Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

split admissionregistration.v1beta1/Webhook into MutatingWebhook and ValidatingWebhook #78491

Closed
wants to merge 2 commits into from
Closed

split admissionregistration.v1beta1/Webhook into MutatingWebhook and ValidatingWebhook #78491

wants to merge 2 commits into from

Conversation

jpbetz
Copy link
Contributor

@jpbetz jpbetz commented May 29, 2019

What type of PR is this?
/kind feature

What this PR does / why we need it:

Per discussions in the mutating admission plugin reinvocation design (kubernetes/enhancements#1049) we need to split these types before introducing the ReinvocationPolicy field.

NONE

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. release-note-none Denotes a PR that doesn't merit a release note. kind/feature Categorizes issue or PR as related to a new feature. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels May 29, 2019
@k8s-ci-robot k8s-ci-robot requested review from deads2k and eparis May 29, 2019 19:25
@k8s-ci-robot k8s-ci-robot added area/apiserver area/test kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/testing Categorizes an issue or PR as relevant to SIG Testing. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels May 29, 2019
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 29, 2019
@jpbetz jpbetz force-pushed the webhook-split branch 4 times, most recently from f8176b7 to 78767d6 Compare May 29, 2019 23:38
@k8s-ci-robot k8s-ci-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels May 29, 2019
@jpbetz jpbetz force-pushed the webhook-split branch 4 times, most recently from 7d21e7f to f20dacf Compare May 30, 2019 01:30
@liggitt liggitt added this to the v1.15 milestone May 30, 2019
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 30, 2019
@jpbetz jpbetz mentioned this pull request May 30, 2019
Merged
@jpbetz
Copy link
Contributor Author

jpbetz commented May 30, 2019

/test pull-kubernetes-integration

liggitt
liggitt reviewed May 30, 2019
View reviewed changes
Copy link
Member

@liggitt liggitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this looks really good, just a few nits. go ahead and squash down to generated/non-generated commits

fwiw, I also tested this with #78309 and json/proto/yaml serialization/deserialization/round-tripping had no complaints against 1.14.0 and master data

staging/src/k8s.io/apiserver/pkg/admission/configuration/validating_webhook_manager.go Outdated Show resolved Hide resolved
staging/src/k8s.io/apiserver/pkg/admission/plugin/webhook/accessors.go Outdated Show resolved Hide resolved
staging/src/k8s.io/apiserver/pkg/admission/plugin/webhook/accessors.go Outdated Show resolved Hide resolved
staging/src/k8s.io/apiserver/pkg/admission/plugin/webhook/util/client_config.go Outdated Show resolved Hide resolved
@jpbetz jpbetz force-pushed the webhook-split branch 2 times, most recently from f325812 to 625e9a6 Compare May 30, 2019 04:33
@jpbetz
Copy link
Contributor Author

jpbetz commented May 30, 2019

go ahead and squash down to generated/non-generated commits

Done. I'll keep an eye on CI.

@liggitt
Copy link
Member

liggitt commented May 30, 2019

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 30, 2019
@liggitt
Copy link
Member

liggitt commented May 30, 2019

/retest

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jpbetz, liggitt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 30, 2019
@jpbetz
Copy link
Contributor Author

jpbetz commented May 30, 2019

/retest

@liggitt liggitt mentioned this pull request May 30, 2019
Merged
@jpbetz jpbetz mentioned this pull request May 30, 2019
Closed
@sttts
Copy link
Contributor

sttts commented May 30, 2019

Well done!

This was referenced May 30, 2019
Closed
Merged
@liggitt
Copy link
Member

liggitt commented May 31, 2019

/hold

code-freeze queue management :)
this is included in #78505 which is already reviewed/approved and in the merge queue, so when that merges, it will include these commits

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 31, 2019
@fedebongio
Copy link
Contributor

/cc @jennybuckley

@k8s-ci-robot k8s-ci-robot requested a review from jennybuckley May 31, 2019 20:13
@liggitt
Copy link
Member

liggitt commented Jun 1, 2019

merged in #78505

/close

@k8s-ci-robot
Copy link
Contributor

@liggitt: Closed this PR.

In response to this:

merged in #78505

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@liggitt liggitt liggitt left review comments

@deads2k deads2k Awaiting requested review from deads2k

@eparis eparis Awaiting requested review from eparis

@jennybuckley jennybuckley Awaiting requested review from jennybuckley

Assignees

@liggitt liggitt

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/apiserver area/test cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note-none Denotes a PR that doesn't merit a release note. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
API Reviews
Status: API review completed, 1.15
Milestone
v1.15
Development

Successfully merging this pull request may close these issues.
5 participants
@jpbetz @liggitt @k8s-ci-robot @sttts @fedebongio