Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Apply algorithm in scheduler by feature gates. #52723

Merged
merged 1 commit into from
Oct 3, 2017
Merged

Apply algorithm in scheduler by feature gates. #52723

merged 1 commit into from
Oct 3, 2017

Conversation

k82cn
Copy link
Member

@k82cn k82cn commented Sep 19, 2017 •
edited
Loading

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): part of #42001

Release note:

Apply algorithm in scheduler by feature gates.

@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Sep 19, 2017
@k82cn k82cn changed the title Added e2e for TaintNodeByCondition. WIP: Added e2e for TaintNodeByCondition. Sep 19, 2017
@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 19, 2017
@k82cn k82cn self-assigned this Sep 19, 2017
@k8s-github-robot k8s-github-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Sep 19, 2017
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Sep 23, 2017
@k82cn k82cn changed the title WIP: Added e2e for TaintNodeByCondition. WIP: Added integration test for TaintNodeByCondition. Sep 24, 2017
@k82cn
Copy link
Member Author

k82cn commented Sep 24, 2017

/cc @gmarek

Working on the integration test for TaintNodeByCondition :).

@k8s-ci-robot k8s-ci-robot requested a review from gmarek September 24, 2017 04:19
@k82cn k82cn force-pushed the k8s_42001_5 branch 3 times, most recently from de7fb14 to 13fcf4a Compare September 24, 2017 13:18
@k8s-github-robot k8s-github-robot removed the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 24, 2017
@davidopp davidopp mentioned this pull request Sep 24, 2017
Closed
7 tasks
@k82cn k82cn force-pushed the k8s_42001_5 branch 7 times, most recently from 7871224 to b1f3422 Compare September 26, 2017 03:43
gmarek
gmarek reviewed Sep 26, 2017
View reviewed changes
test/integration/scheduler/taint_test.go Outdated
nil,
clientset,
time.Second,
100,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

either use named variables for all those values, or add comments by them explaining which is what.

@k82cn k82cn force-pushed the k8s_42001_5 branch 2 times, most recently from 1d608ef to 9261c6f Compare September 26, 2017 15:09
@gmarek
Copy link
Contributor

gmarek commented Sep 27, 2017

/retest

kevin-wangzefeng
kevin-wangzefeng reviewed Sep 29, 2017
View reviewed changes
plugin/pkg/scheduler/algorithmprovider/plugins_test.go Outdated
// Apply features for algorithm providers.
utilfeature.DefaultFeatureGate.Set("TaintNodesByCondition=True")

ApplyFeatures()
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/ApplyFeatures/ApplyFeatureGates/

@bsalamat
Copy link
Member

/lgtm

Thanks, @k82cn!

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 29, 2017
@k8s-github-robot k8s-github-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 1, 2017
@k82cn
Copy link
Member Author

k82cn commented Oct 1, 2017

/retest

@k82cn
Copy link
Member Author

k82cn commented Oct 1, 2017

@gmarek , do nodeController part ok to you?

@k82cn
Copy link
Member Author

k82cn commented Oct 3, 2017

/assign @gmarek

@gmarek
Copy link
Contributor

gmarek commented Oct 3, 2017

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 3, 2017
@k8s-github-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bsalamat, gmarek, k82cn

Associated issue: 42001

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@k8s-github-robot k8s-github-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 3, 2017
@k8s-github-robot
Copy link

/test all [submit-queue is verifying that this PR is safe to merge]

@k82cn
Copy link
Member Author

k82cn commented Oct 3, 2017

/retest

@k8s-github-robot
Copy link

Automatic merge from submit-queue (batch tested with PRs 52723, 53271). If you want to cherry-pick this change to another branch, please follow the instructions here.

@k8s-github-robot k8s-github-robot merged commit 0c6970b into kubernetes:master Oct 3, 2017
@k82cn k82cn deleted the k8s_42001_5 branch October 3, 2017 12:17
@rohitagarwal003
Copy link
Member

@k82cn This caused GKE GPU tests and GKE Device plugin tests to fail:

Diff between passing and failing runs:
924bd56...4c115a8

GKE Device Plugin Tests:
https://k8s-testgrid.appspot.com/wg-resource-management#gke-device-plugin-gpu
https://k8s-gubernator.appspot.com/build/kubernetes-jenkins/logs/ci-kubernetes-e2e-gke-device-plugin-gpu/95

GKE GPU Tests:
https://k8s-testgrid.appspot.com/wg-resource-management#gke-gpu
https://k8s-gubernator.appspot.com/build/kubernetes-jenkins/logs/ci-kubernetes-e2e-gke-gpu/1453

/cc @vishh @jiayingz

@k8s-ci-robot k8s-ci-robot requested review from jiayingz and vishh October 3, 2017 18:01
@rohitagarwal003 rohitagarwal003 mentioned this pull request Oct 3, 2017
Closed
@k82cn
Copy link
Member Author

k82cn commented Oct 4, 2017

wow, let me handle that :).

@bsalamat bsalamat mentioned this pull request Oct 4, 2017
Closed
@wojtek-t wojtek-t mentioned this pull request Oct 11, 2017
Closed
@k82cn k82cn mentioned this pull request Oct 12, 2017
Closed
@k82cn k82cn mentioned this pull request Oct 21, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bsalamat bsalamat bsalamat left review comments

@kevin-wangzefeng kevin-wangzefeng kevin-wangzefeng left review comments

@gmarek gmarek gmarek left review comments

@jiayingz jiayingz Awaiting requested review from jiayingz

@vishh vishh Awaiting requested review from vishh

Assignees

@gmarek gmarek

@bsalamat bsalamat

@k82cn k82cn

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@k82cn @gmarek @bsalamat @k8s-github-robot @rohitagarwal003 @kevin-wangzefeng @k8s-ci-robot