Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

promote DisableNodeKubeProxyVersion feature gate to beta #123845

Merged
merged 1 commit into from
May 8, 2024
Merged

promote DisableNodeKubeProxyVersion feature gate to beta #123845

merged 1 commit into from
May 8, 2024

Conversation

HirazawaUi
Copy link
Contributor

@HirazawaUi HirazawaUi commented Mar 10, 2024 •
edited
Loading

What type of PR is this?

/kind feature

What this PR does / why we need it:

In KEP, we plan to promote the DisableNodeKubeProxyVersion feature gate to the beta version in version 1.31

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Graduated the `DisableNodeKubeProxyVersion` feature gate to beta. By default, the kubelet no longer attempts to set the `.status.kubeProxyVersion` field for its associated Node.

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

- [KEP]: https://github.com/kubernetes/enhancements/tree/master/keps/sig-network/4004-deprecate-kube-proxy-version

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/feature Categorizes issue or PR as related to a new feature. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. area/code-generation area/test kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. sig/testing Categorizes an issue or PR as relevant to SIG Testing. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Mar 10, 2024
@k8s-triage-robot
Copy link

This PR may require API review.

If so, when the changes are ready, complete the pre-review checklist and request an API review.

Status of requested reviews is tracked in the API Review project.

@HirazawaUi HirazawaUi force-pushed the promote-DisableNodeKubeProxyVersion-to-beta branch 2 times, most recently from 656815c to 00e5075 Compare March 12, 2024 13:29
@k8s-ci-robot k8s-ci-robot added area/kubelet sig/node Categorizes an issue or PR as relevant to SIG Node. labels Mar 12, 2024
@HirazawaUi HirazawaUi mentioned this pull request Mar 12, 2024
Open
16 tasks
@HirazawaUi
Copy link
Contributor Author

/cc @danwinship

@k8s-ci-robot k8s-ci-robot requested a review from danwinship March 12, 2024 14:48
@sftim
Copy link
Contributor

sftim commented Mar 12, 2024

Changelog suggestion

-Set the DisableNodeKubeProxyVersion feature gate to be enabled by default.. it will stop setting the KubeProxyVersion field.
+Graduated the `DisableNodeKubeProxyVersion` feature gate to beta.
+By default, the kubelet no longer attempts to set the `.status.kubeProxyVersion` field for its associated
+Node.

@jiahuif
Copy link
Member

jiahuif commented Mar 12, 2024

/remove-sig api-machinery

@k8s-ci-robot k8s-ci-robot removed the sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. label Mar 12, 2024
@bart0sh
Copy link
Contributor

bart0sh commented Mar 14, 2024

/triage accepted

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Mar 14, 2024
@HirazawaUi
Copy link
Contributor Author

/sig network

@k8s-ci-robot k8s-ci-robot added the sig/network Categorizes an issue or PR as relevant to SIG Network. label Mar 14, 2024
danwinship
danwinship reviewed Apr 13, 2024
View reviewed changes
test/e2e/cloud/gcp/common/upgrade_mechanics.go Outdated

if len(kpv) != 0 {
return fmt.Errorf("node %s had kube-proxy version %s which should be empty",
n.ObjectMeta.Name, kpv)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The test shouldn't just assume that the feature gate is set to its default value; you can run the tests with various combinations of feature gates.

You can either check the feature gate here and then check the appropriate result depending on that, or else ignore the feature gate and make the test accept either value ("empty" or "matches kubelet version").

(Yeah, this should have been changed in alpha.)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can either check the feature gate here and then check the appropriate result depending on that, or else ignore the feature gate and make the test accept either value ("empty" or "matches kubelet version").

We can't seem to detect whether the feature gate is enable in the e2e test, so I choose accept either value.

pkg/features/kube_features.go Show resolved Hide resolved
@danwinship
Copy link
Contributor

/milestone v1.31

@k8s-ci-robot k8s-ci-robot added this to the v1.31 milestone Apr 13, 2024
@HirazawaUi HirazawaUi force-pushed the promote-DisableNodeKubeProxyVersion-to-beta branch from 00e5075 to 98c29f0 Compare April 14, 2024 12:33
@k8s-ci-robot k8s-ci-robot added the sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. label Apr 14, 2024
@HirazawaUi
Copy link
Contributor Author

/retest

thockin
thockin reviewed May 8, 2024
View reviewed changes
Copy link
Member

@thockin thockin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 8, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 1f88789001d332db35d8ebf5e6ff90d356846c6b

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: HirazawaUi, thockin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 8, 2024
@k8s-ci-robot k8s-ci-robot merged commit 1af6bc9 into kubernetes:master May 8, 2024
17 checks passed
@Shubham82 Shubham82 mentioned this pull request Jun 24, 2024
Merged
@a-mccarthy a-mccarthy mentioned this pull request Jul 18, 2024
Merged
@liggitt
Copy link
Member

liggitt commented Aug 15, 2024

this is clearing a GA field, we should have given a year from deprecation announcement before defaulting on (announced in 1.29, default on in 1.33)

reverting in #126720

@liggitt liggitt mentioned this pull request Aug 15, 2024
Merged
@ialidzhikov ialidzhikov mentioned this pull request Aug 29, 2024
Open
16 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thockin thockin thockin left review comments

@danwinship danwinship danwinship left review comments

@dchen1107 dchen1107 Awaiting requested review from dchen1107

@justinsb justinsb Awaiting requested review from justinsb

Assignees

@thockin thockin

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/code-generation area/kubelet area/test cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. sig/network Categorizes an issue or PR as relevant to SIG Network. sig/node Categorizes an issue or PR as relevant to SIG Node. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
SIG Node: code and documentation PRs
Archived in project
Milestone
v1.31
Development

Successfully merging this pull request may close these issues.
9 participants
@HirazawaUi @k8s-triage-robot @sftim @jiahuif @bart0sh @danwinship @k8s-ci-robot @liggitt @thockin