Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AWS: add accounts for kops #5128

Merged
merged 1 commit into from
Apr 19, 2023
Merged

Conversation

ameukam
Copy link
Member

@ameukam ameukam commented Apr 14, 2023

Ref:

kops-infra-ci will be used to run e2e tests until we switch to boskos.

kops-infra-services will be used to provision services needed to run kops e2e tests like Route53 or S3.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. area/infra Infrastructure management, infrastructure design, code in infra/ area/infra/aws Issues or PRs related to Kubernetes AWS infrastructure sig/k8s-infra Categorizes an issue or PR as relevant to SIG K8s Infra. labels Apr 14, 2023
@k8s-ci-robot k8s-ci-robot requested review from dims and thockin April 14, 2023 11:26
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ameukam

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 14, 2023
@ameukam
Copy link
Member Author

ameukam commented Apr 14, 2023

/assign @justinsb

@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Apr 14, 2023
Ref: kubernetes#5127

- `kops-infra-ci` will be used to run e2e tests until we switch to
  boskos
- `kops-infra-services` will be used to provision services needed to run
  kops e2e tests like Route53 or S3.

Signed-off-by: Arnaud Meukam <[email protected]>
@ameukam ameukam force-pushed the kops-aws-accounts branch from 5c3000f to df65c78 Compare April 14, 2023 19:56
@justinsb
Copy link
Member

Thanks @ameukam

/lgtm

/hold until you're ready to apply

@k8s-ci-robot k8s-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. lgtm "Looks good to me", indicates that a PR is ready to be merged. labels Apr 18, 2023
@ameukam
Copy link
Member Author

ameukam commented Apr 19, 2023

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 19, 2023
@k8s-ci-robot k8s-ci-robot merged commit 62c9c6c into kubernetes:main Apr 19, 2023
@k8s-ci-robot k8s-ci-robot added this to the v1.28 milestone Apr 19, 2023
@ameukam
Copy link
Member Author

ameukam commented Apr 19, 2023

Accounts created:

aws organizations list-accounts --query "Accounts[?Status=='ACTIVE'].{Name: Name, Email: Email}" | grep 'kops-infra'
[email protected]  kops-infra-services
[email protected]   kops-infra-ci

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/infra/aws Issues or PRs related to Kubernetes AWS infrastructure area/infra Infrastructure management, infrastructure design, code in infra/ cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/k8s-infra Categorizes an issue or PR as relevant to SIG K8s Infra. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants