-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
KEP-4330: match beta goal version ranges to version ranges in beta graduation criteria (N-3) #4989
base: master
Are you sure you want to change the base?
Conversation
zjs
commented
Dec 11, 2024
- One-line PR description: Correct typos in goals section.
- Issue link: Introduce compatibility version for Kubernetes control-plane upgrades #4330
- Other comments: The beta graduation criteria express a wider range of support for the compatibility and emulation versions (N-3 minor versions) than the beta portion of the goals section (N-1 minor versions). The content of other sections, including the example in Feature Gate Lifecycles, and the discussion in KEP-4330: Compatibility versions #4395 suggests N-3 was intended. Fix for clarity.
The beta graduation criteria express a wider range of support for the compatibility and emulation versions (N-3 minor versions) than the beta portion of the goals section (N-1 minor versions). The content of other sections, including the example in Feature Gate Lifecycles, and the discussion in kubernetes#4395 suggests N-3 was intended.
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: zjs The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Welcome @zjs! |
Hi @zjs. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/lgtm |