Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mark KEP implementable and add test plan #1805

Merged
merged 3 commits into from
Jun 3, 2020
Merged

Mark KEP implementable and add test plan #1805

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
938b8bb
Mark KEP implementable and add test plan
arjunrn May 21, 2020
86418dc
Added gjtempleton as a reviewer and approver
arjunrn Jun 3, 2020
37e75d0
Update the last_updated timestamp
arjunrn Jun 3, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 13 additions & 3 deletions keps/sig-autoscaling/0001-container-resource-autoscaling.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,11 +6,13 @@ owning-sig: sig-autoscaling
reviewers:
- "@josephburnett"
- "@mwielgus"
- "@gjtempleton"
approvers:
- "@josephburnett"
- "@gjtempleton"
creation-date: 2020-02-18
last-updated: 2020-02-18
status: provisional
last-updated: 2020-06-03
status: implementable
---

# Kubernetes Enhancement Proposal Process
Expand Down Expand Up @@ -290,7 +292,15 @@ There will be no deprecation warning or internal migrations from `ResourceMetric
## Design Details

### Test Plan
TBD
Most of the tests will follow the same pattern as the tests for the pod resource metric source. The following
unit tests will be added:

- **Replica Calculator:** Verify that the number of replicas calculated is based on the metrics of individual
containers when a container metric source is specified.
- **REST Metrics Client:** Verify that the resources returned from the REST metric client is the metrics for only
the containers specified in the metric source.
- **API server validation:** Verify that only valid container metric sources are accepted.
- **kubectl:** Verify that the new metric sources are displayed correctly.

### Graduation Criteria

Expand Down