Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove scheduler policy config and cc v1beta1 #2901

Closed
8 tasks done
kerthcet opened this issue Aug 26, 2021 · 19 comments
Closed
8 tasks done

Remove scheduler policy config and cc v1beta1 #2901

kerthcet opened this issue Aug 26, 2021 · 19 comments
Assignees
Labels
sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling.

Comments

@kerthcet
Copy link
Member

kerthcet commented Aug 26, 2021

Enhancement Description

Please keep this description up to date. This will help the Enhancement Team to track the evolution of the enhancement efficiently.

@k8s-ci-robot k8s-ci-robot added the needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. label Aug 26, 2021
@kerthcet
Copy link
Member Author

/sig scheduling

@k8s-ci-robot k8s-ci-robot added sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Aug 26, 2021
@kerthcet
Copy link
Member Author

KEP is in progress⚽️

@kerthcet
Copy link
Member Author

/assign

@kerthcet kerthcet changed the title Remove scheduler policy config in 1.23 Remove scheduler policy config and mark cc v1beta1 as deprecated Sep 1, 2021
@kerthcet kerthcet changed the title Remove scheduler policy config and mark cc v1beta1 as deprecated Remove scheduler policy config and cc v1beta1 Sep 1, 2021
@kerthcet
Copy link
Member Author

Remove v1beta1 pending for review.

@kerthcet
Copy link
Member Author

kerthcet commented Oct 3, 2021

remove scheduler policy config is in draft now.

@Huang-Wei
Copy link
Member

@kerthcet just a heads-up: when you work on "remove ServiceAffinity plugin", please also remove the event registration logic here:

https://github.com/kubernetes/kubernetes/blob/0ac956ff2bef9c84b17d4b9cae2cffe71d5c6386/pkg/scheduler/eventhandlers.go#L417-L423

@kerthcet
Copy link
Member Author

kerthcet commented Oct 4, 2021

@kerthcet just a heads-up: when you work on "remove ServiceAffinity plugin", please also remove the event registration logic here:

https://github.com/kubernetes/kubernetes/blob/0ac956ff2bef9c84b17d4b9cae2cffe71d5c6386/pkg/scheduler/eventhandlers.go#L417-L423

gotcha

@kerthcet
Copy link
Member Author

remove plugin service-affinity pending for review.

@kerthcet
Copy link
Member Author

sorry to disturb you @Huang-Wei , I was wondering whether LegacyRegistry and Policy should also be removed? thanks.

@Huang-Wei
Copy link
Member

Huang-Wei commented Oct 10, 2021

@kerthcet commented on the PR. We should get rid of the ServiceAffinity plugin only.

@Huang-Wei
Copy link
Member

sorry to disturb you @Huang-Wei , I was wondering whether LegacyRegistry and Policy should also be removed? thanks.

@kerthcet Yes, we'd like to remove all Policy bits. Given it may involve a lot of API changes, would you mind leaving it to @ahg-g ?

@kerthcet
Copy link
Member Author

sure, i think i can learn a lot from him also.

@kerthcet
Copy link
Member Author

kerthcet commented Nov 5, 2021

Since the last subtask about k/website docs is done, all the subtasks are finished now, I'll try to close this issue. Thanks for all you guys help.
/cc @Huang-Wei @ahg-g @alculquicondor @damemi

What's more, I'll open another pr about the policy config migration from v1beta2 -> v1beta3 in k/website as suggested later.

@kerthcet kerthcet closed this as completed Nov 5, 2021
@alculquicondor
Copy link
Member

alculquicondor commented Nov 5, 2021

/reopen

Do not close until all the tasks have been completed, including documentation.

Don't forget to open the PR against the dev-1.23 branch.

@k8s-ci-robot
Copy link
Contributor

@alculquicondor: Reopened this issue.

In response to this:

/reopen

Do not close until all the tasks have been completed, including documentation.

Don't forge to open the PR against the dev-1.23 branch.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot reopened this Nov 5, 2021
@kerthcet
Copy link
Member Author

since kubernetes/website#30404 is closed, close this issue then. cc @alculquicondor

@kerthcet
Copy link
Member Author

/close

@k8s-ci-robot
Copy link
Contributor

@kerthcet: Closing this issue.

In response to this:

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@alculquicondor
Copy link
Member

I just realized that this was opened under the enhancements repo. Since this was just a KEP update, rather than it's own KEP:

  • It should link to the original KEP and its issue
  • It shouldn't say alpha (the KEP is beta already)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling.
Projects
None yet
Development

No branches or pull requests

4 participants