Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release 2.3.1 #86

Merged
merged 1 commit into from
Apr 24, 2019
Merged

Release 2.3.1 #86

merged 1 commit into from
Apr 24, 2019

Conversation

cofyc
Copy link
Member

@cofyc cofyc commented Apr 24, 2019 •
edited
Loading

fixes #57

  • update README.md and CHANGELOG.md
  • upgrade helm chart to 2.3.1

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cofyc

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 24, 2019
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Apr 24, 2019
@cofyc
Copy link
Member Author

cofyc commented Apr 24, 2019

/assign @msau42
By the way, after this PR is merged, could you create a tag 2.3.1 and push it?
Our release job should build an image for the new tag automatically. If it fails I will build the image manually.

msau42
msau42 reviewed Apr 24, 2019
View reviewed changes
README.md Outdated
| [1.0.1][1] | 1.7 | |
| Provisioner version | K8s version | Reason |
| ------------------- | ------------- | --------------------------- |
| [2.3.1][5] | 1.14 | local persistent volumes GA |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's no new features in 2.3.1 that depend on 1.14 is there? Should we just update 2.3.0 to 2.3.1?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed, you are right, it is version compatibility

msau42
msau42 reviewed Apr 24, 2019
View reviewed changes
README.md Outdated
@@ -80,6 +80,7 @@ Recommended provisioner versions with Kubernetes versions

| Provisioner version | K8s version | Reason |
| ------------------- | ------------- | ------------------------- |
| [2.3.1][5] | 1.12 | |
| [2.3.0][4] | 1.12 | fs on block support |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe just replace 2.3.0 with 2.3.1? It's the same minor release train.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

msau42
msau42 reviewed Apr 24, 2019
View reviewed changes
CHANGELOG.md
([#60](https://github.com/kubernetes-sigs/sig-storage-local-static-provisioner/pull/60))

Deployment updates:
- Support pod security policy
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do any of these deployment updates depend on newer than 1.12?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no

@msau42
Copy link
Contributor

msau42 commented Apr 24, 2019

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 24, 2019
@k8s-ci-robot k8s-ci-robot merged commit 7270021 into kubernetes-sigs:master Apr 24, 2019
@cofyc cofyc deleted the fix57 branch April 28, 2019 06:55
davidmccormick pushed a commit to davidmccormick/sig-storage-local-static-provisioner that referenced this pull request Mar 31, 2021
@k8s-ci-robot
Merge pull request kubernetes-sigs#86 from cofyc/fix57
e107609 
Release 2.3.1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@msau42 msau42 msau42 left review comments

@jsafrane jsafrane Awaiting requested review from jsafrane

@saad-ali saad-ali Awaiting requested review from saad-ali

Assignees

@msau42 msau42

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Prepare a new release
3 participants
@cofyc @k8s-ci-robot @msau42