Remove misleading documentation about config generation #5716
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
kind/cleanup
k8s-ci-robot
added
the
size/XS
|
/kind documentation |
k8s-ci-robot
added
the
kind/documentation
|
Hi there, @VannTen! Could you please rebase your PR? It appears we had a linting issue on |
ConfigMap are not garbage collected, see kubernetes-sigs#3146
VannTen
force-pushed
the
cleanup/wrong_example_config_gen
branch
from
72da1ab to
05339da
Compare
|
done 👍 |
|
/assign @stormqueen1990 |
k8s-ci-robot
added
the
lgtm
|
Thanks @VannTen |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: koba1t, VannTen The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
/kind cleanup
Follow-up to #3146, cleaning examples as well.
(Note that this files appeart pretty high in search results when looking for "kustomize configmap generation", so I guess I'm not the first one to be confused ^)