-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Drop go-getter use. #3586
Drop go-getter use. #3586
Conversation
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: monopole The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
so kustomize is no longer supporting building from remote repos? just checking that I understand the purpose of this PR |
It still supports URLs like
|
go-getter is the first method kustomize tries to get the remote resources. After removing it the secondary method (git cloner) will be the primary one. It may break some users' remote resources and probably reduce performance but we have to do it since license issue and massive dependencies. |
/lgtm |
Under the hood, it uses The argument to The URL is passed to a subprocess that runs |
Fix #3578
Only the first commit (d564df5) has manual changes, the rest is due to
go tidy
etc. Lots of deps are dropped.The
build
command's help had to be changed since it mentioned gogettter; took the opportunity to make the cobra command object more reusable, so we have the option of using it directly in kubectl.ALLOW_MODULE_SPAN