Add example for kustomize build {url} and remote bases #264
Conversation
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Liujingfang1 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
approved
Liujingfang1
force-pushed
the
docs
branch
2 times, most recently
from
3888dfc to
816bee8
Compare
k8s-ci-robot
added
size/L
Liujingfang1
changed the title
examples/remoteBuild.md
Outdated
|
|
||
|
|
||
| The url should follow | ||
| [hashicorp/go-getter URL format](https://github.com/hashicorp/go-getter#url-format) |
There was a problem hiding this comment.
Missing a period at end of sentence.
examples/remoteBuild.md
Outdated
|
|
||
| ## kustomize build {URL} | ||
|
|
||
| `kustomize build` can be run against a url. The effect is the same as cloing the repo, checking out the specified ref, |
There was a problem hiding this comment.
I think the entire doc here should start with this sentence.
The current first section offers a list of example URLs. That would be better at the end.
examples/remoteBuild.md
Outdated
| test 3 == \ | ||
| $(kustomize build github.com/kubernetes-sigs/kustomize//examples/multibases?ref=v1.0.6 | grep cluster-a-.*-myapp-pod | wc -l); \ | ||
| echo $? | ||
| ``` |
There was a problem hiding this comment.
Great example. Suggest making it more legible, e.g.
target=github.com/kubernetes-sigs/kustomize//examples/multibases?ref=v1.0.6
test 3 == \
$(kustomize build $target | grep cluster-a-.*-myapp-pod | wc -l); \
echo $?
examples/remoteBuild.md
Outdated
| ## remote {URL} in bases | ||
|
|
||
| Similarly, the remote url can be used as a base in an overlay. Take the same url `github.com/kubernetes-sigs/kustomize//examples/multibases?ref=v1.0.6` as an example. | ||
| An overaly can be simpliy created on top of it. |
There was a problem hiding this comment.
Suggest shortening this to just:
A base can also be specified as a URL:
| test 3 == \ | ||
| $(kustomize build $DEMO_HOME | grep remote-.*-myapp-pod | wc -l); \ | ||
| echo $? | ||
| ``` |
|
Updated the example according to comments. PTAL @monopole |
k8s-ci-robot
added
the
lgtm
Fix #254
kustomize build --help