Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplify git cloner logic #2080

Merged
merged 1 commit into from
Jan 13, 2020
Merged

Simplify git cloner logic #2080

merged 1 commit into from
Jan 13, 2020

Conversation

yujunz
Copy link
Member

@yujunz yujunz commented Jan 11, 2020

Related to #2072

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jan 11, 2020
@yujunz
Copy link
Member Author

yujunz commented Jan 11, 2020

Refer to https://stackoverflow.com/questions/21833870/how-do-i-shallow-clone-a-repo-on-a-specific-branch

@Liujingfang1
Copy link
Contributor

/lgtm

@yujunz Did you verify the change on #2072

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 13, 2020
@monopole
Copy link
Contributor

yeah, this used to be "clone" then "checkout {branch}" in two steps (pre #857). thanks

/lgtm

As @Liujingfang1 suggests, please add Fixes #2072 to the description if that error goes away on your fork.

monopole
monopole approved these changes Jan 13, 2020
View reviewed changes
Copy link
Contributor

@monopole monopole left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: monopole, yujunz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 13, 2020
@k8s-ci-robot k8s-ci-robot merged commit 1a330f8 into kubernetes-sigs:master Jan 13, 2020
@yujunz
Copy link
Member Author

yujunz commented Jan 14, 2020

@yujunz Did you verify the change on #2072

Yes. I verified it locally.

@yujunz yujunz deleted the git-cloner branch January 14, 2020 00:58
@yujunz
Copy link
Member Author

yujunz commented Jan 14, 2020

As @Liujingfang1 suggests, please add Fixes #2072 to the description if that error goes away on your fork.

It seems already merged. Will do next time.

Some repository will prevent issues from closing automatically so I didn't add the trigger.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@monopole monopole monopole approved these changes

@droot droot Awaiting requested review from droot

Assignees

@monopole monopole

@Liujingfang1 Liujingfang1

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@yujunz @Liujingfang1 @monopole @k8s-ci-robot