-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add example plugin for go-getter #1488
Conversation
f361584
to
ed91bce
Compare
3e5a80b
to
93dbc1f
Compare
This allows one to use non-kustomization remote source
93dbc1f
to
ed920af
Compare
# name: example | ||
# url: github.com/kustless/kustomize-examples.git | ||
# # subPath: base # (optional) relative path in the package | ||
# # command: cat *.yaml # (optional) build command, default `kustomize build $subPath` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The command
can be optional. When the url contains a kustomization.yaml
, this plugin should be able to auto check it and trigger kustomize build on it. When the url doesn't contain a kustomization.yaml
, this plugin can load all the yaml files that have apiVersion
and kind
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
auto check might be overkilled for a simple shell script.
Consider the use case of downloading ksonnet or helmfile configuration or selectively apply part of the downloaded manifests.
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Liujingfang1, yujunz The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
#923