Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add example plugin for go-getter #1488

Merged
merged 3 commits into from
Sep 5, 2019

Conversation

yujunz
Copy link
Member

@yujunz yujunz commented Aug 30, 2019

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Aug 30, 2019
@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Aug 30, 2019
@yujunz yujunz changed the title Add example plugin for go-getter (#923) Add example plugin for go-getter Aug 30, 2019
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Sep 2, 2019
This allows one to use non-kustomization remote source
examples/goGetterGeneratorPlugin.md Outdated Show resolved Hide resolved
examples/goGetterGeneratorPlugin.md Outdated Show resolved Hide resolved
examples/goGetterGeneratorPlugin.md Show resolved Hide resolved
examples/goGetterGeneratorPlugin.md Outdated Show resolved Hide resolved
# name: example
# url: github.com/kustless/kustomize-examples.git
# # subPath: base # (optional) relative path in the package
# # command: cat *.yaml # (optional) build command, default `kustomize build $subPath`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The command can be optional. When the url contains a kustomization.yaml, this plugin should be able to auto check it and trigger kustomize build on it. When the url doesn't contain a kustomization.yaml, this plugin can load all the yaml files that have apiVersion and kind.

Copy link
Member Author

@yujunz yujunz Sep 5, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

auto check might be overkilled for a simple shell script.

Consider the use case of downloading ksonnet or helmfile configuration or selectively apply part of the downloaded manifests.

@Liujingfang1
Copy link
Contributor

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 5, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Liujingfang1, yujunz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 5, 2019
@k8s-ci-robot k8s-ci-robot merged commit f87edc8 into kubernetes-sigs:master Sep 5, 2019
@yujunz yujunz deleted the plugin/go-getter branch September 6, 2019 01:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants