Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert go plugin example to GPG based #1350

Merged
merged 3 commits into from
Jul 17, 2019
Merged

Convert go plugin example to GPG based #1350

merged 3 commits into from
Jul 17, 2019

Conversation

yujunz
Copy link
Member

@yujunz yujunz commented Jul 14, 2019

No description provided.

@k8s-ci-robot k8s-ci-robot requested review from mengqiy and monopole July 14, 2019 03:35
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jul 14, 2019
@Liujingfang1
Copy link
Contributor

Can we keep the existing one and adding the gpg based secret generator? Maybe in the same doc or a separate doc. I'm fine with both.

@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jul 16, 2019
@yujunz
Copy link
Member Author

yujunz commented Jul 16, 2019

Can we keep the existing one and adding the gpg based secret generator? Maybe in the same doc

Done

@Liujingfang1 Liujingfang1 self-assigned this Jul 16, 2019
@Liujingfang1
Copy link
Contributor

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 17, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Liujingfang1, yujunz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 17, 2019
@k8s-ci-robot k8s-ci-robot merged commit 7632839 into kubernetes-sigs:master Jul 17, 2019
@yujunz yujunz deleted the docs/plugins branch January 31, 2020 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Liujingfang1 Liujingfang1 Liujingfang1 left review comments

@mengqiy mengqiy Awaiting requested review from mengqiy

@monopole monopole Awaiting requested review from monopole

Assignees

@Liujingfang1 Liujingfang1

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@yujunz @Liujingfang1 @k8s-ci-robot