Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Addresses issue discovered in attempting to patch K8s objects across different namespaces. #1206

Merged
merged 1 commit into from
Jun 19, 2019
Merged

Addresses issue discovered in attempting to patch K8s objects across different namespaces. #1206

merged 1 commit into from
Jun 19, 2019

Conversation

jbrette
Copy link
Contributor

@jbrette jbrette commented Jun 19, 2019 •
edited
Loading

  • Return an error when findTarget fails.
  • Add unit test testing the change.

This address the issue related here: #1203

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jun 19, 2019
@k8s-ci-robot k8s-ci-robot requested review from droot and justinsb June 19, 2019 13:32
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: jbrette
To complete the pull request process, please assign droot
You can assign the PR to them by writing /assign @droot in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jun 19, 2019
@jbrette jbrette changed the title Addresses issue with variables declared in different namespaces. Addresses issue discovered in attempting to patch K8s objects across different namespaces. Jun 19, 2019
@jbrette
Attempting to patch K8s objects across different namespaces.
934e036 
- Return an error when findTarget fails.
- Add unit test testing the change.
monopole
monopole approved these changes Jun 19, 2019
View reviewed changes
Copy link
Contributor

@monopole monopole left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Duh! Especially thanks for the improved test coverage.
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 19, 2019
@monopole monopole merged commit b08f338 into kubernetes-sigs:master Jun 19, 2019
@jbrette jbrette deleted the namespace branch June 19, 2019 20:24
This was referenced Jun 20, 2019
Closed
Closed
@pst pst mentioned this pull request Jun 27, 2019
Merged
@jinchihe jinchihe mentioned this pull request Jul 8, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@monopole monopole monopole approved these changes

@droot droot Awaiting requested review from droot

@justinsb justinsb Awaiting requested review from justinsb

Assignees

@monopole monopole

Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jbrette @k8s-ci-robot @monopole