Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Job spec/template/spec/volumes/projected/sources/configMap/name missing in configmap transformer #1322

Closed
waldiTM opened this issue Jul 9, 2019 · 9 comments
Labels
kind/bug Categorizes issue or PR as related to a bug. lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed.

Comments

@waldiTM
Copy link

waldiTM commented Jul 9, 2019

kustomize 433733e does not transform generate configMap names inside projected volumes of jobs. The following entry is missing:

- kind: ConfigMap
  version: v1
  fieldSpecs:
  - path: spec/template/spec/volumes/projected/sources/configMap/name
    kind: Job
@Liujingfang1
Copy link
Contributor

@waldiTM Thank you for reporting the missing piece. Feel free to open a PR to add it.

@yujunz
Copy link
Member

yujunz commented Jul 10, 2019

It seems not just missing this one. Is the list crafted manually?

yujunz added a commit to yujunz/kustomize that referenced this issue Jul 10, 2019
yujunz added a commit to yujunz/kustomize that referenced this issue Jul 10, 2019
@Liujingfang1
Copy link
Contributor

It seems not just missing this one. Is the list crafted manually?

Yes

@Liujingfang1 Liujingfang1 added the kind/bug Categorizes issue or PR as related to a bug. label Jul 10, 2019
yujunz added a commit to yujunz/kustomize that referenced this issue Jul 11, 2019
@waldiTM
Copy link
Author

waldiTM commented Jul 14, 2019

@waldiTM Thank you for reporting the missing piece. Feel free to open a PR to add it.

Can't do that due to CLA problems.

@waldiTM
Copy link
Author

waldiTM commented Jul 16, 2019

Also missing:

+  - path: spec/template/spec/volumes/projected/sources/configMap/name
+    kind: DaemonSet

richardmarshall pushed a commit to richardmarshall/kustomize that referenced this issue Aug 13, 2019
@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Oct 14, 2019
@fejta-bot
Copy link

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle rotten

@k8s-ci-robot k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Nov 13, 2019
@fejta-bot
Copy link

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/close

@k8s-ci-robot
Copy link
Contributor

@fejta-bot: Closing this issue.

In response to this:

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Categorizes issue or PR as related to a bug. lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed.
Projects
None yet
Development

No branches or pull requests

5 participants