Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

registry: add ingress support #8311

Merged
merged 1 commit into from
Dec 21, 2021
Merged

registry: add ingress support #8311

merged 1 commit into from
Dec 21, 2021

Conversation

zhengtianbao
Copy link
Member

What type of PR is this?

/kind feature

What this PR does / why we need it:

This PR is the third step to implement the proposal #8221 .

Now user can configure an Ingress to give Registry Services externally-reachable traffic (with or without SSL / TLS) and offer name-based virtual hosting.

Does this PR introduce a user-facing change?:

Add Ingress support to container registry (using new variables `registry_ingress_annotations`, `registry_ingress_host`, `registry_ingress_tls_secret`)

@k8s-ci-robot k8s-ci-robot added kind/feature Categorizes issue or PR as related to a new feature. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Dec 16, 2021
cristicalin
cristicalin approved these changes Dec 17, 2021
View reviewed changes
Copy link
Contributor

@cristicalin cristicalin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@zhengtianbao 👍

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 17, 2021
@oomichi
Copy link
Contributor

oomichi commented Dec 21, 2021

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cristicalin, oomichi, zhengtianbao

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 21, 2021
@k8s-ci-robot k8s-ci-robot merged commit 02a8954 into kubernetes-sigs:master Dec 21, 2021
@zhengtianbao zhengtianbao mentioned this pull request Dec 22, 2021
Merged
@floryut floryut mentioned this pull request Dec 22, 2021
Closed
sakuraiyuta pushed a commit to sakuraiyuta/kubespray that referenced this pull request Apr 16, 2022
@zhengtianbao @sakuraiyuta
registry: add ingress support (kubernetes-sigs#8311)
c8659c4
LuckySB pushed a commit to southbridgeio/kubespray that referenced this pull request Jun 29, 2023
@zhengtianbao @LuckySB
registry: add ingress support (kubernetes-sigs#8311)
0b7297d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cristicalin cristicalin cristicalin approved these changes

@oomichi oomichi Awaiting requested review from oomichi

Assignees

@oomichi oomichi

@cristicalin cristicalin

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@zhengtianbao @oomichi @k8s-ci-robot @cristicalin