Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add Gather facts to remove-node.yml #8231

Merged
merged 1 commit into from
Nov 29, 2021

Conversation

ikrozhkov
Copy link
Contributor

@ikrozhkov ikrozhkov commented Nov 25, 2021

What type of PR is this?
/kind bug

What this PR does / why we need it:
If we want to remove node from cluster we should follow this guide, but because of this condition it will fail:

TASK [reset : reset | Restart network] ****************************************************************************************************************************************************************fatal: [mynode1]: FAILED! => {"msg": "The conditional check 'ansible_os_family not in ["Flatcar", "Flatcar Container Linux by Kinvolk"]' failed. The error was: error while evaluating conditional (ansible_os_family not in ["Flatcar", "Flatcar Container Linux by Kinvolk"]): 'ansible_os_family' is undefined\n\nThe error appears to be in '/data/mvp/kubespray/roles/reset/tasks/main.yml': line 384, column 3, but may\nbe elsewhere in the file depending on the exact syntax problem.\n\nThe offending line appears to be:\n\n\n- name: reset | Restart network\n ^ here\n"}

It happens due to the fact that we are not gathering facts about removable node. If we include this task to remove-node.yml as in this PR issue will be solved.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

Add gather facts to remove-node playbook to prevent issue with os evaluation

@k8s-ci-robot k8s-ci-robot added the kind/bug Categorizes issue or PR as related to a bug. label Nov 25, 2021
@k8s-ci-robot
Copy link
Contributor

Hi @ikrozhkov. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Nov 25, 2021
@cristicalin
Copy link
Contributor

/retest

@cristicalin
Copy link
Contributor

@ikrozhkov I think this PR needs a rebase.

@cristicalin
Copy link
Contributor

Thank you for this fix @ikrozhkov !

/ok-to-test
/lgtm

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Nov 27, 2021
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 27, 2021
@ikrozhkov
Copy link
Contributor Author

Thank you for this fix @ikrozhkov !

/ok-to-test /lgtm

Thanks for review!

Copy link
Member

@floryut floryut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ikrozhkov Thanks for the PR 👍

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: floryut, IKRozhkov

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 29, 2021
@k8s-ci-robot k8s-ci-robot merged commit 09c17ba into kubernetes-sigs:master Nov 29, 2021
@ikrozhkov ikrozhkov deleted the draft branch November 29, 2021 10:11
@floryut floryut mentioned this pull request Dec 21, 2021
sakuraiyuta pushed a commit to sakuraiyuta/kubespray that referenced this pull request Apr 16, 2022
LuckySB pushed a commit to southbridgeio/kubespray that referenced this pull request Jun 28, 2023
sw-cho pushed a commit to sw-cho/kubespray that referenced this pull request Feb 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants