Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Registry add TLS and authentication support #8229

Merged
merged 2 commits into from
Dec 7, 2021
Merged

Registry add TLS and authentication support #8229

merged 2 commits into from
Dec 7, 2021

Conversation

zhengtianbao
Copy link
Member

@zhengtianbao zhengtianbao commented Nov 25, 2021

What type of PR is this?

/kind feature

What this PR does / why we need it:

This PR is the first step to implement the proposal #8221 .

includes:

  1. now registry can use the TLS secrets by user created, and listen on port 443 by default with the TLS certificate.

  2. now registry supports htpasswd as basic authentication.

  3. now registry strips out the configuration items to ConfigMap, user has a more detailed configuration strategy.

Special notes for your reviewer:

I'd like to test this feature at CI, but I don't know how to add the testcase, any suggestions are greatly appreciated.

Does this PR introduce a user-facing change?:

Add TLS and authentication support to container registry (using new variables `registry_tls_secret`, `registry_htpasswd`, `registry_config`)

@k8s-ci-robot k8s-ci-robot added kind/feature Categorizes issue or PR as related to a new feature. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Nov 25, 2021
@k8s-ci-robot
Copy link
Contributor

Hi @zhengtianbao. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Nov 25, 2021
@cristicalin
Copy link
Contributor

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Dec 4, 2021
@floryut
Copy link
Member

floryut commented Dec 6, 2021

@zhengtianbao You need to rebase master first 👍

Copy link
Contributor

@cristicalin cristicalin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @zhengtianbao !

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 6, 2021
@oomichi
Copy link
Contributor

oomichi commented Dec 7, 2021

/lgtm
/cc @floryut

Copy link
Member

@floryut floryut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@zhengtianbao Thanks 👍

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cristicalin, floryut, zhengtianbao

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 7, 2021
@k8s-ci-robot k8s-ci-robot merged commit 4ef2cf4 into kubernetes-sigs:master Dec 7, 2021
nmasse-itix pushed a commit to nmasse-itix/kubespray that referenced this pull request Dec 8, 2021
* Add registry TLS support

* Add registry configmap and htpasswd auth
@floryut floryut mentioned this pull request Dec 21, 2021
sakuraiyuta pushed a commit to sakuraiyuta/kubespray that referenced this pull request Apr 16, 2022
* Add registry TLS support

* Add registry configmap and htpasswd auth
LuckySB pushed a commit to southbridgeio/kubespray that referenced this pull request Jun 28, 2023
* Add registry TLS support

* Add registry configmap and htpasswd auth
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants