-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Registry add TLS and authentication support #8229
Registry add TLS and authentication support #8229
Conversation
Hi @zhengtianbao. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/ok-to-test |
@zhengtianbao You need to rebase master first 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @zhengtianbao !
/lgtm
/lgtm |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@zhengtianbao Thanks 👍
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cristicalin, floryut, zhengtianbao The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
* Add registry TLS support * Add registry configmap and htpasswd auth
* Add registry TLS support * Add registry configmap and htpasswd auth
* Add registry TLS support * Add registry configmap and htpasswd auth
What type of PR is this?
/kind feature
What this PR does / why we need it:
This PR is the first step to implement the proposal #8221 .
includes:
now registry can use the TLS secrets by user created, and listen on port 443 by default with the TLS certificate.
now registry supports
htpasswd
as basic authentication.now registry strips out the configuration items to
ConfigMap
, user has a more detailed configuration strategy.Special notes for your reviewer:
I'd like to test this feature at CI, but I don't know how to add the testcase, any suggestions are greatly appreciated.
Does this PR introduce a user-facing change?: