Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump crun version 1.2 to 1.3 #8162

Merged
merged 1 commit into from
Nov 6, 2021

Conversation

eminaktas
Copy link
Contributor

Signed-off-by: Emin Aktaş [email protected]
Co-authored-by: Yasin Taha Erol [email protected]
Co-authored-by: Necatican Yıldırım [email protected]

What type of PR is this?
/kind feature

What this PR does / why we need it:
Adds support for crun v1.3
Which issue(s) this PR fixes:

Fixes #8161

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

Changed the default crun version to v1.3

Signed-off-by: Emin Aktaş <[email protected]>
Co-authored-by: Yasin Taha Erol <[email protected]>
Co-authored-by: Necatican Yıldırım <[email protected]>
@k8s-ci-robot k8s-ci-robot added kind/feature Categorizes issue or PR as related to a new feature. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Nov 5, 2021
@k8s-ci-robot
Copy link
Contributor

Welcome @eminaktas!

It looks like this is your first PR to kubernetes-sigs/kubespray 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/kubespray has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Nov 5, 2021
@k8s-ci-robot
Copy link
Contributor

Hi @eminaktas. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Nov 5, 2021
@k8s-ci-robot k8s-ci-robot requested review from bozzo and EppO November 5, 2021 14:35
@floryut floryut added the release-note-none Denotes a PR that doesn't merit a release note. label Nov 5, 2021
Copy link
Member

@floryut floryut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ok-to-test
@eminaktas Thank you for the PR 👍

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Nov 5, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: eminaktas, floryut

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 5, 2021
@oomichi
Copy link
Contributor

oomichi commented Nov 5, 2021

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 5, 2021
@cristicalin
Copy link
Contributor

/ok-to-test

@k8s-ci-robot k8s-ci-robot merged commit 58390c7 into kubernetes-sigs:master Nov 6, 2021
@eminaktas eminaktas deleted the crun_new_version branch November 7, 2021 04:54
sakuraiyuta pushed a commit to sakuraiyuta/kubespray that referenced this pull request Apr 16, 2022
Signed-off-by: Emin Aktaş <[email protected]>
Co-authored-by: Yasin Taha Erol <[email protected]>
Co-authored-by: Necatican Yıldırım <[email protected]>

Co-authored-by: Yasin Taha Erol <[email protected]>
Co-authored-by: Necatican Yıldırım <[email protected]>
LuckySB pushed a commit to southbridgeio/kubespray that referenced this pull request Jun 28, 2023
Signed-off-by: Emin Aktaş <[email protected]>
Co-authored-by: Yasin Taha Erol <[email protected]>
Co-authored-by: Necatican Yıldırım <[email protected]>

Co-authored-by: Yasin Taha Erol <[email protected]>
Co-authored-by: Necatican Yıldırım <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Crun v1.3 support
5 participants