-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ensure addon-resizer 1.8.11 only effective at arch amd64. #8144
Ensure addon-resizer 1.8.11 only effective at arch amd64. #8144
Conversation
Welcome @zhengtianbao! |
Hi @zhengtianbao. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
k8s.gcr.io/addon-resizer:1.8.11 returns the amd64 image which is not executable at arm64. Disable addon-resizer when the platform is not amd64. When metrics-server upgrade and use addon-resizer:2.3, then revert this commit and `image_arch` will determine the `addon_resizer_image_tag`.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@zhengtianbao Thank you for the PR
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: floryut, zhengtianbao The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/cc @oomichi
@@ -81,7 +81,7 @@ spec: | |||
requests: | |||
cpu: {{ metrics_server_requests_cpu }} | |||
memory: {{ metrics_server_requests_memory }} | |||
{% if metrics_server_resizer %} | |||
{% if metrics_server_resizer and host_architecture == "amd64" %} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How about adding a check into roles/kubernetes-apps/metrics_server/tasks/main.yml instead?
That would be helpful to let operators know the metrics_server_resizer is not available on other architectures than amd64:
- name: check host_architecture is amd64 for metrics_server_resizer
assert:
that: host_architecture == "amd64"
when: metrics_server_resizer
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your advice, done.
Thanks for updating. /ok-to-test |
/lgtm |
…-sigs#8144) * Ensure addon-resizer 1.8.11 only effective at arch amd64. k8s.gcr.io/addon-resizer:1.8.11 returns the amd64 image which is not executable at arm64. Disable addon-resizer when the platform is not amd64. When metrics-server upgrade and use addon-resizer:2.3, then revert this commit and `image_arch` will determine the `addon_resizer_image_tag`. * Add metrics_server_resizer architectures check
…-sigs#8144) * Ensure addon-resizer 1.8.11 only effective at arch amd64. k8s.gcr.io/addon-resizer:1.8.11 returns the amd64 image which is not executable at arm64. Disable addon-resizer when the platform is not amd64. When metrics-server upgrade and use addon-resizer:2.3, then revert this commit and `image_arch` will determine the `addon_resizer_image_tag`. * Add metrics_server_resizer architectures check
k8s.gcr.io/addon-resizer:1.8.11 returns the amd64 image which is not executable at arm64.
Disable addon-resizer when the platform is not amd64.
When metrics-server upgrade and use addon-resizer:2.3, then revert this
commit and
image_arch
will determine theaddon_resizer_image_tag
.What type of PR is this?
/kind bug
What this PR does / why we need it:
Disable addon-resizer of metrics-server except at platform amd64 because of k8s.gcr.io/addon-resizer:1.8.11 image only support architecture amd64.
Which issue(s) this PR fixes:
Fixes #8121
Special notes for your reviewer:
Does this PR introduce a user-facing change?: