nginx ingress controller should watch kind:ingress without class #8128
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
the
size/XS
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: LuckySB The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
oomichi
reviewed
Oct 28, 2021
| @@ -52,6 +52,8 @@ spec: | |||
| - --annotations-prefix=nginx.ingress.kubernetes.io | |||
| {% if ingress_nginx_class is defined %} | |||
| - --ingress-class={{ ingress_nginx_class }} | |||
| {% else %} | |||
| - --watch-ingress-without-class=true | |||
There was a problem hiding this comment.
If you don't care about ingressClass, or you have a lot of ingress objects without
ingressClass configuration, you can run the ingress-controller with the flag
--watch-ingress-without-class=true
this seems good for me.
k8s-ci-robot
added
the
lgtm
Closed
notCalle
pushed a commit
to ModioAB/kubespray
that referenced
this pull request
Feb 8, 2022
…ernetes-sigs#8128) (cherry picked from commit 0b441ad)
notCalle
pushed a commit
to ModioAB/kubespray
that referenced
this pull request
Feb 10, 2022
…ernetes-sigs#8128) (cherry picked from commit 0b441ad)
notCalle
pushed a commit
to ModioAB/kubespray
that referenced
this pull request
Feb 10, 2022
…ernetes-sigs#8128) (cherry picked from commit 0b441ad)
sakuraiyuta
pushed a commit
to sakuraiyuta/kubespray
that referenced
this pull request
Apr 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What this PR does / why we need it:
Newly version nginx ingress controller ignoring Kind: ingress without class by default
rancher/rancher#35053
Ignoring ingress because of error while validating ingress class" ingress="cattle-system/rancher" error="ingress does not contain a valid IngressClassDoes this PR introduce a user-facing change?: