Fix quorum check when recovering broken etcd cluster (with etcd 3.5.x) #8126
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Skipping CI for Draft Pull Request. |
k8s-ci-robot
added
do-not-merge/work-in-progress
k8s-ci-robot
added
approved
k8s-ci-robot
added
size/S
floryut
force-pushed
the
etcd_debug
branch
5 times, most recently
from
b853a86 to
1a009ef
Compare
k8s-ci-robot
added
size/M
floryut
changed the title
floryut
changed the title
k8s-ci-robot
added
size/S
|
❌ Failed nightly : ✔️ Green jobs with fix : |
k8s-ci-robot
removed
the
do-not-merge/work-in-progress
k8s-ci-robot
added
size/XS
floryut
commented
Oct 26, 2021
| @@ -20,10 +20,9 @@ | |||
| when: | |||
| - groups['broken_etcd'] | |||
|
|
|||
| # When there is an error, everything is printed in stderr_lines, even "is healthy" messages. | |||
There was a problem hiding this comment.
Not anymore 🎉 @EppO do you remember our etcd 3.4.x crusade ? brings back some memories 😆
|
/approve |
cristicalin
approved these changes
Oct 26, 2021
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cristicalin, floryut The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/lgtm |
k8s-ci-robot
added
the
lgtm
Closed
sakuraiyuta
pushed a commit
to sakuraiyuta/kubespray
that referenced
this pull request
Apr 16, 2022
LuckySB
pushed a commit
to southbridgeio/kubespray
that referenced
this pull request
Jun 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind bug
What this PR does / why we need it:
Since updating to etcd 3.5.x, the recover broken etcd role is failing.
A bug introduced in 3.4.x has been fixed in 3.5.x, the bug was sending every output to error if the cluster was unhealthy when using the endpoint_health command.
The second changes is related to
etcdctl member listtaking a few seconds to display the newly created members, so retry is now needed.Which issue(s) this PR fixes:
None
Special notes for your reviewer:
etcdctl endpoint healthfor a broken etcd cluster with 3.4.x version:etcdctl endpoint healthfor a broken etcd cluster with 3.5.x version:Does this PR introduce a user-facing change?: