cert-manager: upgrade to 1.5.4

[cristicalin]

What type of PR is this?

/kind feature

What this PR does / why we need it:
This PR upgrades cert-manager to 1.5.4 and brings our templates closer to the upstream artifacts.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:
This will need to be rebased after #8064 is merged since that one fixes a deployment issue of cert-manager.

Does this PR introduce a user-facing change?:

Cert-manager: upgrade to 1.5.4

[k8s-ci-robot]

Hi @cristicalin. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[cristicalin]

/cc @rtsp

[k8s-ci-robot]

@cristicalin: GitHub didn't allow me to request PR reviews from the following users: rtsp.

Note that only kubernetes-sigs members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

/cc @rtsp

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[rtsp]

I really love your idea to simplify the imports using type: all. 😂😂

[cristicalin]

I really love your idea to simplify the imports using type: all. 😂😂

I think the type field is something we never quite implemented so it's just a label, you can put whatever you want

[rtsp]

Also, this is minor, but I think cert-manager should written in all lowercase.

Writing “cert-manager”

cert-manager should always be written in lowercase. Even when it would normally be capitalized such as in titles or at the start of sentences. A hyphen should always be used between the words, don’t replace it with a space or remove it.

https://cert-manager.io/v1.5-docs/faq/style/

[floryut]

I really love your idea to simplify the imports using type: all. 😂😂

I think the type field is something we never quite implemented so it's just a label, you can put whatever you want

you are quite right, I don't see any use in the python lib with this field..

[floryut]

/ok-to-test
Let's see if the CI is happy with this, but good job man! thx

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cristicalin, floryut

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [floryut]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[cristicalin]

@floryut I strongly suspect it will continue to fail until #8064 is merged and this PR is rebased on it.

[floryut]

@floryut I strongly suspect it will continue to fail until #8064 is merged and this PR is rebased on it.

Indeed, brain didn't start right away on monday, I remembered that this was a followup of the cert-manager pr fix after commenting 😄

[oomichi]

#8064 is going to be merged.
Let's rebase this after that.

[cristicalin]

Done. Since, the previous MR did not address the docs cleanup I added a commit to this one to remove outdated information regarding the pre-created ClusterIssuer.

[floryut]

Done. Since, the previous MR did not address the docs cleanup I added a commit to this one to remove outdated information regarding the pre-created ClusterIssuer.

And some linting issue 😆

./docs/cert_manager.md:14 MD012/no-multiple-blanks Multiple consecutive blank lines [Expected: 1; Actual: 2]

[cristicalin]

And some linting issue 😆

Fixed now, ... mental note, add linter to the local pre-commit hook

[oomichi]

Thanks for rebasing.

/lgtm