-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add option to set different server group policy for etcd, node, and master server #8046
Add option to set different server group policy for etcd, node, and master server #8046
Conversation
Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA. It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Welcome @OlleLarsson! |
Hi @OlleLarsson. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
0b6404a
to
4415218
Compare
99c0073
to
ea79b8e
Compare
ea79b8e
to
5ffa236
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
LGTM |
/ok-to-test |
Thank you @OlleLarsson for this fix! /lgtm |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for all the look on this PR 🙇
And good job @OlleLarsson
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: floryut, OlleLarsson, Xartos The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
What this PR does / why we need it:
In the current release it is only possible to enable openstack server groups with a fixed policy of "anti-affinity" set for all server groups.
Hard anti-affinity might be fine when running on hyperscalar openstack clouds, but it quickly becomes a problem when running on smaller openstack clouds where the number of available compute nodes is not that great.
This pr enables enabling server groups and setting the desired policy for each individual server group.
Setting
equates to the same bahaviour as
did.
Which issue(s) this PR fixes:
NA
Special notes for your reviewer:
Does this PR introduce a user-facing change?: