Upgrade ruamel.yaml.clib to work with Python 3.10 #8034
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ruamel.yaml.clib did not build with the upcoming Python 3.10. Cf. https://sourceforge.net/p/ruamel-yaml-clib/tickets/5/ ruamel.yaml.clib==0.2.4 fixes the issue. It does not work with Python 3.7 (cf https://sourceforge.net/p/ruamel-yaml-clib/tickets/6/) but currently Kubespray requires Python >= 3.9.
k8s-ci-robot
added
kind/bug
|
Hi @olivierlemasle. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
k8s-ci-robot
added
the
size/XS
k8s-ci-robot
added
ok-to-test
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: floryut, olivierlemasle The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
floryut
added
kind/feature
k8s-ci-robot
added
the
approved
|
/lgtm |
k8s-ci-robot
added
the
lgtm
isantospardo
pushed a commit
to isantospardo/kubespray
that referenced
this pull request
Nov 11, 2021
ruamel.yaml.clib did not build with the upcoming Python 3.10. Cf. https://sourceforge.net/p/ruamel-yaml-clib/tickets/5/ ruamel.yaml.clib==0.2.4 fixes the issue. It does not work with Python 3.7 (cf https://sourceforge.net/p/ruamel-yaml-clib/tickets/6/) but currently Kubespray requires Python >= 3.9.
isantospardo
pushed a commit
to isantospardo/kubespray
that referenced
this pull request
Nov 18, 2021
ruamel.yaml.clib did not build with the upcoming Python 3.10. Cf. https://sourceforge.net/p/ruamel-yaml-clib/tickets/5/ ruamel.yaml.clib==0.2.4 fixes the issue. It does not work with Python 3.7 (cf https://sourceforge.net/p/ruamel-yaml-clib/tickets/6/) but currently Kubespray requires Python >= 3.9.
oomichi
pushed a commit
to oomichi/kubespray
that referenced
this pull request
Nov 18, 2021
ruamel.yaml.clib did not build with the upcoming Python 3.10. Cf. https://sourceforge.net/p/ruamel-yaml-clib/tickets/5/ ruamel.yaml.clib==0.2.4 fixes the issue. It does not work with Python 3.7 (cf https://sourceforge.net/p/ruamel-yaml-clib/tickets/6/) but currently Kubespray requires Python >= 3.9.
k8s-ci-robot
pushed a commit
that referenced
this pull request
Nov 19, 2021
* Fix-CI: python was upgraded in CI to 3.10 and pathlib is now included in python base making this dependency break the CI (#8153) * Upgrade ruamel.yaml.clib to work with Python 3.10 (#8034) ruamel.yaml.clib did not build with the upcoming Python 3.10. Cf. https://sourceforge.net/p/ruamel-yaml-clib/tickets/5/ ruamel.yaml.clib==0.2.4 fixes the issue. It does not work with Python 3.7 (cf https://sourceforge.net/p/ruamel-yaml-clib/tickets/6/) but currently Kubespray requires Python >= 3.9. Co-authored-by: Cristian Calin <[email protected]> Co-authored-by: Olivier Lemasle <[email protected]>
Closed
sakuraiyuta
pushed a commit
to sakuraiyuta/kubespray
that referenced
this pull request
Apr 16, 2022
ruamel.yaml.clib did not build with the upcoming Python 3.10. Cf. https://sourceforge.net/p/ruamel-yaml-clib/tickets/5/ ruamel.yaml.clib==0.2.4 fixes the issue. It does not work with Python 3.7 (cf https://sourceforge.net/p/ruamel-yaml-clib/tickets/6/) but currently Kubespray requires Python >= 3.9.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind bug
What this PR does / why we need it:
This commit upgrades
ruamel.yaml.clibto work with the upcoming Python 3.10.Cf. https://sourceforge.net/p/ruamel-yaml-clib/tickets/5/
Which issue(s) this PR fixes:
N∕A
Special notes for your reviewer:
ruamel.yaml.clib==0.2.4fixes the Python 3.10 issue and works with Python 3.9.It does not work with Python 3.7 (cf https://sourceforge.net/p/ruamel-yaml-clib/tickets/6/) but currently Kubespray requires Python >= 3.9.
Does this PR introduce a user-facing change?: