Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 'stable' and 'edge' keys in docker_cli_versioned_pkg dict #8019

Merged

Conversation

electrocucaracha
Copy link
Contributor

@electrocucaracha electrocucaracha commented Sep 24, 2021

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespaces from that line:

/kind api-change

/kind bug

/kind cleanup
/kind design
/kind documentation
/kind failing-test
/kind feature
/kind flake

What this PR does / why we need it:
Using stable value as docker_version configuration value raises the following error:

fatal: [fv-az39-792]: FAILED! => {"msg": "The conditional check 'docker_package_info.pkgs|length > 0' failed. The error was: error while evaluating conditional (docker_package_info.pkgs|length > 0): AnsibleMapping([('pkgs', ['{{ containerd_versioned_pkg[containerd_version | string] }}', '{{ docker_cli_versioned_pkg[docker_cli_version | string] }}', '{{ docker_versioned_pkg[docker_version | string] }}'])]): 'dict object' has no attribute 'stable'\n\nThe error appears to be in '/opt/kubespray/roles/container-engine/docker/tasks/main.yml': line 107, column 3, but may\nbe elsewhere in the file depending on the exact syntax problem.\n\nThe offending line appears to be:\n\n\n- name: ensure docker packages are installed\n  ^ here\n"}

This is caused by missing the entries in the docker_cli_versioned_pkg dictionary.

Which issue(s) this PR fixes:
This change adds those values into the dictionaries defined on every distribution

Special notes for your reviewer:
This hasn't covered by any Use Case in the CI.

Does this PR introduce a user-facing change?:

Add missing 'stable' and 'edge' keys in `docker_cli_versioned_pkg` dict

@k8s-ci-robot k8s-ci-robot added kind/bug Categorizes issue or PR as related to a bug. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Sep 24, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: electrocucaracha, floryut

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 27, 2021
@oomichi
Copy link
Contributor

oomichi commented Sep 27, 2021

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 27, 2021
@k8s-ci-robot k8s-ci-robot merged commit 9416c9a into kubernetes-sigs:master Sep 27, 2021
LuckySB pushed a commit to southbridgeio/kubespray that referenced this pull request Oct 23, 2021
@electrocucaracha electrocucaracha deleted the fix_docker_cli_version branch November 2, 2021 18:04
@floryut floryut mentioned this pull request Dec 21, 2021
sakuraiyuta pushed a commit to sakuraiyuta/kubespray that referenced this pull request Apr 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants