Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove allowPrivilegeEscalation from metrics-server #8014

Merged
merged 1 commit into from
Sep 27, 2021
Merged

Remove allowPrivilegeEscalation from metrics-server #8014

merged 1 commit into from
Sep 27, 2021

Conversation

oomichi
Copy link
Contributor

@oomichi oomichi commented Sep 24, 2021 •
edited by floryut
Loading

What type of PR is this?

/kind bug

What this PR does / why we need it:

"allowPrivilegeEscalation: false" blocks deploying metrics-server on CentOS7 with the error message in the pod:

panic: failed to create listener: failed to listen on 0.0.0.0:443: listen tcp 0.0.0.0:443: bind: permission denied

goroutine 1 [running]:
main.main()
        /go/src/sigs.k8s.io/metrics-server/cmd/metrics-server/metrics-server.go:39 +0x105

In addition, the original metrics-server manifest doesn't contain it as 1.
This removes it.

Which issue(s) this PR fixes:

Fixes #7988

Does this PR introduce a user-facing change?:

Fix CentOS7 issue with allowPrivilegeEscalation value from metrics-server

Remove allowPrivilegeEscalation from metrics-server
6794fd6 
"allowPrivilegeEscalation: false" blocks deploying metrics-server
on CentOS7. In addition, the original metrics-server manifest doesn't
contain it as [1]. This removes it.

[1]: https://github.com/kubernetes-sigs/metrics-server/blob/527679e5e8a103919c935d0575c20741796bc25d/manifests/base/deployment.yaml
@k8s-ci-robot k8s-ci-robot added kind/bug Categorizes issue or PR as related to a bug. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Sep 24, 2021
@k8s-ci-robot k8s-ci-robot requested review from bozzo and EppO September 24, 2021 01:36
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: floryut, oomichi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 24, 2021
@oomichi oomichi mentioned this pull request Sep 24, 2021
Closed
@floryut floryut added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 27, 2021
@k8s-ci-robot k8s-ci-robot merged commit d27cf37 into kubernetes-sigs:master Sep 27, 2021
oomichi added a commit to oomichi/kubespray that referenced this pull request Sep 27, 2021
@oomichi
Remove allowPrivilegeEscalation from metrics-server (kubernetes-sigs#…
9591a0f 
…8014)

"allowPrivilegeEscalation: false" blocks deploying metrics-server
on CentOS7. In addition, the original metrics-server manifest doesn't
contain it as [1]. This removes it.

[1]: https://github.com/kubernetes-sigs/metrics-server/blob/527679e5e8a103919c935d0575c20741796bc25d/manifests/base/deployment.yaml
@oomichi oomichi mentioned this pull request Sep 27, 2021
Merged
k8s-ci-robot pushed a commit that referenced this pull request Sep 28, 2021
@oomichi
Remove allowPrivilegeEscalation from metrics-server (#8014) (#8025)
6cfa3bb 
"allowPrivilegeEscalation: false" blocks deploying metrics-server
on CentOS7. In addition, the original metrics-server manifest doesn't
contain it as [1]. This removes it.

[1]: https://github.com/kubernetes-sigs/metrics-server/blob/527679e5e8a103919c935d0575c20741796bc25d/manifests/base/deployment.yaml
LuckySB pushed a commit to southbridgeio/kubespray that referenced this pull request Oct 23, 2021
@oomichi @LuckySB
Remove allowPrivilegeEscalation from metrics-server (kubernetes-sigs#…
a23e956 
…8014)

"allowPrivilegeEscalation: false" blocks deploying metrics-server
on CentOS7. In addition, the original metrics-server manifest doesn't
contain it as [1]. This removes it.

[1]: https://github.com/kubernetes-sigs/metrics-server/blob/527679e5e8a103919c935d0575c20741796bc25d/manifests/base/deployment.yaml
@floryut floryut mentioned this pull request Dec 21, 2021
Closed
sakuraiyuta pushed a commit to sakuraiyuta/kubespray that referenced this pull request Apr 16, 2022
@oomichi @sakuraiyuta
Remove allowPrivilegeEscalation from metrics-server (kubernetes-sigs#…
5ecfdee 
…8014)

"allowPrivilegeEscalation: false" blocks deploying metrics-server
on CentOS7. In addition, the original metrics-server manifest doesn't
contain it as [1]. This removes it.

[1]: https://github.com/kubernetes-sigs/metrics-server/blob/527679e5e8a103919c935d0575c20741796bc25d/manifests/base/deployment.yaml
huangkevin404 pushed a commit to wiremind/kubespray that referenced this pull request Sep 15, 2022
@oomichi
Remove allowPrivilegeEscalation from metrics-server (kubernetes-sigs#…
641a867 
…8014) (kubernetes-sigs#8025)

"allowPrivilegeEscalation: false" blocks deploying metrics-server
on CentOS7. In addition, the original metrics-server manifest doesn't
contain it as [1]. This removes it.

[1]: https://github.com/kubernetes-sigs/metrics-server/blob/527679e5e8a103919c935d0575c20741796bc25d/manifests/base/deployment.yaml
skw0823 pushed a commit to skw0823/kubespray that referenced this pull request Mar 2, 2023
@oomichi
Remove allowPrivilegeEscalation from metrics-server (kubernetes-sigs#…
81c7a3c 
…8014) (kubernetes-sigs#8025)

"allowPrivilegeEscalation: false" blocks deploying metrics-server
on CentOS7. In addition, the original metrics-server manifest doesn't
contain it as [1]. This removes it.

[1]: https://github.com/kubernetes-sigs/metrics-server/blob/527679e5e8a103919c935d0575c20741796bc25d/manifests/base/deployment.yaml
skw0823 pushed a commit to skw0823/kubespray that referenced this pull request Mar 6, 2023
@oomichi
Remove allowPrivilegeEscalation from metrics-server (kubernetes-sigs#…
1d602e9 
…8014) (kubernetes-sigs#8025)

"allowPrivilegeEscalation: false" blocks deploying metrics-server
on CentOS7. In addition, the original metrics-server manifest doesn't
contain it as [1]. This removes it.

[1]: https://github.com/kubernetes-sigs/metrics-server/blob/527679e5e8a103919c935d0575c20741796bc25d/manifests/base/deployment.yaml
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@floryut floryut floryut approved these changes

@bozzo bozzo Awaiting requested review from bozzo

@EppO EppO Awaiting requested review from EppO

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Metrics-server : bind: permission denied
3 participants
@oomichi @k8s-ci-robot @floryut