Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix k8s-certs-renew cp path #7992

Merged
merged 1 commit into from
Sep 21, 2021
Merged

Fix k8s-certs-renew cp path #7992

merged 1 commit into from
Sep 21, 2021

Conversation

lazybetrayer
Copy link
Contributor

@lazybetrayer lazybetrayer commented Sep 20, 2021 •
edited by floryut
Loading

What type of PR is this?

/kind bug

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #7990

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

Fix k8s-certs-renew cp path wrongly using `/usr/bin/`

@k8s-ci-robot k8s-ci-robot added kind/bug Categorizes issue or PR as related to a bug. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Sep 20, 2021
@k8s-ci-robot
Copy link
Contributor

Hi @lazybetrayer. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Sep 20, 2021
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Sep 20, 2021
oomichi
oomichi reviewed Sep 21, 2021
View reviewed changes
Copy link
Contributor

@oomichi oomichi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ok-to-test

roles/kubernetes/control-plane/templates/k8s-certs-renew.sh.j2 Outdated Show resolved Hide resolved
@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Sep 21, 2021
@champtar
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 21, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: floryut, lazybetrayer

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 21, 2021
@k8s-ci-robot k8s-ci-robot merged commit 2211504 into kubernetes-sigs:master Sep 21, 2021
rtsp pushed a commit to rtsp/kubespray that referenced this pull request Sep 23, 2021
@lazybetrayer @rtsp
Fix k8s-certs-renew cp path (kubernetes-sigs#7992)
6b4ccd0 
Signed-off-by: Wang Zhen <[email protected]>
oomichi pushed a commit to oomichi/kubespray that referenced this pull request Sep 28, 2021
@lazybetrayer
Fix k8s-certs-renew cp path (kubernetes-sigs#7992)
e1f905a 
This is a cherry-pick of 2211504

Signed-off-by: Wang Zhen <[email protected]>
k8s-ci-robot pushed a commit that referenced this pull request Sep 29, 2021
@oomichi @lazybetrayer
Fix k8s-certs-renew cp path (#7992) (#8032)
dfee7a8 
This is a cherry-pick of 2211504

Signed-off-by: Wang Zhen <[email protected]>

Co-authored-by: Wang Zhen <[email protected]>
LuckySB pushed a commit to southbridgeio/kubespray that referenced this pull request Oct 23, 2021
@lazybetrayer @LuckySB
Fix k8s-certs-renew cp path (kubernetes-sigs#7992)
e79361d 
Signed-off-by: Wang Zhen <[email protected]>
@floryut floryut mentioned this pull request Dec 21, 2021
Closed
sakuraiyuta pushed a commit to sakuraiyuta/kubespray that referenced this pull request Apr 16, 2022
@lazybetrayer @sakuraiyuta
Fix k8s-certs-renew cp path (kubernetes-sigs#7992)
701baac 
Signed-off-by: Wang Zhen <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oomichi oomichi oomichi left review comments

@floryut floryut floryut approved these changes

@EppO EppO Awaiting requested review from EppO

Assignees

@champtar champtar

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

/usr/local/bin/k8s-certs-renew.sh: line 13: /usr/bin/cp: No such file or directory
5 participants
@lazybetrayer @k8s-ci-robot @champtar @oomichi @floryut