Calico: make calico_min_version check relevant

[cristicalin]

What type of PR is this?

/kind feature

What this PR does / why we need it:
In the kubernetes role we have a validation task which checks for the minimum calico version. This brings our check in line with the lowest supported version.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

[Calico] Make `calico_min_version` check relevant

[k8s-ci-robot]

Hi @cristicalin. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[floryut]

/ok-to-test

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cristicalin, floryut

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [floryut]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[champtar]

The min version should be the minimum version we can update from no ?

[cristicalin]

@champtar actually, the way we check this is not tied to the previous version at all but only on what we have in the inventory: https://github.com/kubernetes-sigs/kubespray/blob/master/roles/kubernetes/preinstall/tasks/0020-verify-settings.yml#L192-L199

This actually checks that the deployer updated their inventory with the minimum supported calico version which, given our policy of not maintaining more than one minor version for each major calico version may mean that it is higher than what was deployed by the previous version of calico (i.e. kubespray 2.15 supported calico 3.17.3 while kubespray 2.16 supports calico 3.17.5). In the end this check is useless and defeated by the check here: https://github.com/kubernetes-sigs/kubespray/blob/master/roles/kubernetes/preinstall/tasks/0020-verify-settings.yml#L50-L57 which validates that the inventory contains an actually supported calico_version and not just a minimum.

Looking at this implementation again, I would actually drop the logic that checks for calico_min_version since it effectively does nothing. We can actually move the check for calico_min_version to this https://github.com/kubernetes-sigs/kubespray/blob/master/roles/kubernetes/preinstall/tasks/0020-verify-settings.yml#L213-L223 which is a more meaningful check that the version actually deployed is compatible to upgrade from.

[cristicalin]

With version 2.17 released, I would like to revive this PR.

/cc @champtar @floryut

[oomichi]

/lgtm