Added ArgoCD kubernetes-app

[atorrescogollo]

What type of PR is this?
/kind feature

What this PR does / why we need it:
Installs ArgoCD as a kubernetes-app. ArgoCD allows you to bootstrap some configurations and manage its state using GitOps.

Which issue(s) this PR fixes:

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

Add ArgoCD as a kubernetes-app, using the new `argocd_enabled` variable

[k8s-ci-robot]

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.

---

• If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
• If you signed the CLA as a corporation, please sign in with your organization's credentials at https://identity.linuxfoundation.org/projects/cncf to be authorized.
• If you have done the above and are still having issues with the CLA being reported as unsigned, please log a ticket with the Linux Foundation Helpdesk: https://support.linuxfoundation.org/
• Should you encounter any issues with the Linux Foundation Helpdesk, send a message to the backup e-mail support address at: [email protected]

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[k8s-ci-robot]

Welcome @atorrescogollo!

It looks like this is your first PR to kubernetes-sigs/kubespray 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/kubespray has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

[k8s-ci-robot]

Hi @atorrescogollo. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[atorrescogollo]

Signed CLA

[atorrescogollo]

/check-cla

[atorrescogollo]

/retest

[k8s-ci-robot]

@atorrescogollo: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[atorrescogollo]

@bozzo @holmsten Hi, failed checks don't seem to be related with the content of this PR. Could you run them again? I also signed CLA

[oomichi]

/check-cla

[atorrescogollo]

Hi @oomichi , thank you. It seems I missed something when I signed the CLA. Now, I have to CNCF Individual Contributor License Agreement, so I guess it is now actually signed.

On the other hand, I don't find any relation of this code with the error in packet_centos8-calico test. It seems the service account "default" was not created in the "test" namespace. But I don't use any of it.

[floryut]

Hi @oomichi , thank you. It seems I missed something when I signed the CLA. Now, I have to CNCF Individual Contributor License Agreement, so I guess it is now actually signed.

On the other hand, I don't find any relation of this code with the error in packet_centos8-calico test. It seems the service account "default" was not created in the "test" namespace. But I don't use any of it.

All good for CLA, regarding the test failure, your branch is oooooooooooooooooooold 😄
Last commit from 20 august means you miss a lot of fixes, so the CI error you have has already been fix but you don't have it

[atorrescogollo]

@floryut you were right. I have already rebased my fork

[liupeng0518]

/ok-to-test

[cristicalin]

Nice work @atorrescogollo! Even though current argocd version is 2.1.6 I think we should merge this and do another PR later to bump to the latest version before we tag 2.18.

/lgtm

[floryut]

@atorrescogollo Thank for this, hope we won't leave it unmaintained 👍

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: atorrescogollo, floryut

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [floryut]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[cristicalin]

@atorrescogollo since you decided to update the argocd version, you will need to also rebase on latest master branch to get some fixes for the CI jobs to pass.

[atorrescogollo]

@cristicalin Already rebased

[cristicalin]

Nice, thanks for the work! Also hoping to keep this maintained over time and in-sync with upstream.

/lgtm