Prefer nodelocaldns as dns server over coredns when defined

[Alvaro-Campesino]

/kind feature

What this PR does / why we need it: This PR gives preferral to nodelocaldns when defined over coredns as dns_server for the kube-nodes and kube-control-plane when resolving internal k8s dns addresses

Which issue(s) this PR fixes:
#7730

Does this PR introduce a user-facing change?:

Prefer nodelocaldns as dns server over coredns when defined

[k8s-ci-robot]

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.

---

• If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
• If you signed the CLA as a corporation, please sign in with your organization's credentials at https://identity.linuxfoundation.org/projects/cncf to be authorized.
• If you have done the above and are still having issues with the CLA being reported as unsigned, please log a ticket with the Linux Foundation Helpdesk: https://support.linuxfoundation.org/
• Should you encounter any issues with the Linux Foundation Helpdesk, send a message to the backup e-mail support address at: [email protected]

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[k8s-ci-robot]

Welcome @Alvaro-Campesino!

It looks like this is your first PR to kubernetes-sigs/kubespray 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/kubespray has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

[k8s-ci-robot]

Hi @Alvaro-Campesino. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[cristicalin]

Nice optimisation!
Thanks for spotting this!

[unai-ttxu]

Hi @Alvaro-Campesino @cristicalin!

I think we should ensure that enable_nodelocaldns is set to true before using nodelocaldns_ip as nameserver. In case nodelocaldns is not deployed, we can maintain coredns_server as first nameserver

[cristicalin]

Good point @unai-ttxu, nodelocaldns can be disabled it would be better to check if it is enabled before putting it in the nameservers list.

Additionally, note that the Ubuntu CI jobs don't support nodelocaldns due to missing kernel modules and the CI jobs will fail due to the current way the PR composes the list.

[Alvaro-Campesino]

Thanks @unai-ttxu I updated the field in order to consider wether enable_nodelocaldns is set to true or not. Please check it out.

[Alvaro-Campesino]

/remove-lifecycle stale

[Alvaro-Campesino]

/assign @LuckySB

[Alvaro-Campesino]

/remove-lifecycle rotten

[Alvaro-Campesino]

/remove-lifecycle stale

[floryut]

/remove-lifecycle stale

@Alvaro-Campesino Truth to be told, I've not check this PR (and I guess reviewers did the same) because the CI is not working with the current patch.. could you take a look ?

[Alvaro-Campesino]

Hi @floryut I fixed the typo error. The remaining CIs still failing doesn't seem to be related to my code, but I might be mistaken

[Alvaro-Campesino]

can you check and approve now @LuckySB

[linux-foundation-easycla]

The committers are authorized under a signed CLA.

• ✅ Alvaro Campesino (6300e84)

[k8s-ci-robot]

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.

---

• If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
• If you signed the CLA as a corporation, please sign in with your organization's credentials at https://identity.linuxfoundation.org/projects/cncf to be authorized.
• If you have done the above and are still having issues with the CLA being reported as unsigned, please log a ticket with the Linux Foundation Helpdesk: https://support.linuxfoundation.org/
• Should you encounter any issues with the Linux Foundation Helpdesk, send a message to the backup e-mail support address at: [email protected]

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[Alvaro-Campesino]

Hi @floryut and @LuckySB it seems everything is fine now and the CI flow passed

[floryut]

@Alvaro-Campesino indeed sorry forgot about this one 👍
/ok-to-test
/cc @cristicalin

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Alvaro-Campesino, floryut

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [floryut]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[Alvaro-Campesino]

The CI failed because an error trying to resolve dns:

failed to resolve reference \\\"quay.io/calico/node:v3.20.3\\\": failed to do request: Head \\\"https://quay.io/v2/calico/node/manifests/v3.20.3\\\": dial tcp: lookup quay.io: Temporary failure in name resolution\""],

T_T

[floryut]

/cc @cristicalin @oomichi
@Alvaro-Campesino Vagrant is flaky that's why it's in an allowed to fail state 😉

[oomichi]

/lgtm