Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add mdba plugin manifest #4240

Merged
merged 4 commits into from
Dec 8, 2024

Conversation

hedgieinsocks
Copy link
Contributor

@hedgieinsocks hedgieinsocks commented Nov 25, 2024

❯ k krew install --manifest=./plugins/mdba.yaml
Installing plugin: mdba
Installed plugin: mdba
\
 | Use this plugin:
 |      kubectl mdba
 | Documentation:
 |      https://github.com/hedgieinsocks/kubectl-mdba
 | Caveats:
 | \
 |  | Dependencies: jq
 | /
/

@ahmetb
Copy link
Member

ahmetb commented Nov 25, 2024

🤖 Beep beep! I’m a robot speaking on behalf of @ahmetb. 🤖


Thanks for submitting your kubectl plugin to Krew!
One of the krew-index maintainers will review it soon. Note that the reviews for new plugin submissions may take a few days.

In the meanwhile, here are a few tips to make your plugin manifest better:

  • Make sure your plugin follows the best practices.
  • Eliminate redundant wording form shortDescription (it should be max 50 characters).
  • Try to word wrap your description to 80-character lines (no usage examples, please).

Thanks for your patience!
/kind new-plugin

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/new-plugin size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Nov 25, 2024
@ahmetb
Copy link
Member

ahmetb commented Dec 7, 2024

The only concern I have is with the name of the plugin. It is not an official plugin of mariadb project -and as I understand it doesn’t support all mariadb clusters, but it grabs the generic popular name of “mdb”. Am I right in this assessment?

@hedgieinsocks
Copy link
Contributor Author

Yes, your assessment is correct.

Since not every krew user will go to the repo to see the disclaimer, I can try to better indicate in the manifest that it's unofficial and has limited functionality.

As for taking the mdb name, I understand your point. Although, they don't seem to have any plans to create an official plugin in the observable future, that could easily change.

If you would like me to choose another name, I'll surely do that. Just need to come up with a good new one))

@hedgieinsocks hedgieinsocks changed the title Add mdb plugin manifest Add mdba plugin manifest Dec 8, 2024
@ahmetb
Copy link
Member

ahmetb commented Dec 8, 2024

/lgtm
/approve
Thanks!
Also, please consider setting up Krew release automation which helps you skip manually making updates to your Krew manifests on each new version and send a pull request. It’s a GitHub workflow bot that can run every time you push a new tag. Those PRs are automatically approved.

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 8, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahmetb, hedgieinsocks

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 8, 2024
@k8s-ci-robot k8s-ci-robot merged commit 3e723a8 into kubernetes-sigs:master Dec 8, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/new-plugin lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants