-
Notifications
You must be signed in to change notification settings - Fork 496
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add mdba plugin manifest #4240
Add mdba plugin manifest #4240
Conversation
hedgieinsocks
commented
Nov 25, 2024
•
edited
Loading
edited
🤖 Beep beep! I’m a robot speaking on behalf of @ahmetb. 🤖 Thanks for submitting your kubectl plugin to Krew! In the meanwhile, here are a few tips to make your plugin manifest better:
Thanks for your patience! |
The only concern I have is with the name of the plugin. It is not an official plugin of mariadb project -and as I understand it doesn’t support all mariadb clusters, but it grabs the generic popular name of “mdb”. Am I right in this assessment? |
Yes, your assessment is correct. Since not every krew user will go to the repo to see the disclaimer, I can try to better indicate in the manifest that it's unofficial and has limited functionality. As for taking the If you would like me to choose another name, I'll surely do that. Just need to come up with a good new one)) |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ahmetb, hedgieinsocks The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |