Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added nodegizmo plugin #3348

Merged
merged 4 commits into from
Sep 19, 2023

Conversation

Kavinraja-G
Copy link
Contributor

Team,

I would like to add my kubectl-plugin nodegizmo in krew index. This is a small utility for your kubernetes nodes providing various features as mentioned here. More to come 🚀

@ahmetb
Copy link
Member

ahmetb commented Sep 9, 2023

🤖 Beep beep! I’m a robot speaking on behalf of @ahmetb. 🤖


Thanks for submitting your kubectl plugin to Krew!
One of the krew-index maintainers will review it soon. Note that the reviews for new plugin submissions may take a few days.

In the meanwhile, here are a few tips to make your plugin manifest better:

  • Make sure your plugin follows the best practices.
  • Eliminate redundant wording form shortDescription (it should be max 50 characters).
  • Try to word wrap your description to 80-character lines (no usage examples, please).

Thanks for your patience!
/kind new-plugin

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Sep 9, 2023
@k8s-ci-robot
Copy link
Contributor

Welcome @Kavinraja-G!

It looks like this is your first PR to kubernetes-sigs/krew-index 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/krew-index has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Sep 9, 2023
@Kavinraja-G
Copy link
Contributor Author

@ahmetb any comments on this PR would be great. TY!

@ahmetb
Copy link
Member

ahmetb commented Sep 16, 2023

Sorry for the latency here. The plugin does not seem to be working out-of-the box.

kubectl nodegizmo
2023/09/16 12:41:38 Error generating md docs for nodegizmo: open docs/nodegizmo_node_capacity.md: no such file or directory

Please ping again when the plugin actually works.
/hold

@ahmetb ahmetb added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 16, 2023
@Kavinraja-G
Copy link
Contributor Author

@ahmetb -- Thanks for the review & pointing that issue. I had fixed the issue and update the PR!

@ahmetb
Copy link
Member

ahmetb commented Sep 19, 2023

@Kavinraja-G just had a chance to review. This plugin is a bit odd because it actually does things that other plugins do. (e.g. ttsum, view-capacity, view-allocations, resource-capacity and nsenter).

There are a few unique aspects such as integrating tighter with the cloud providers, showing machine sizes/OS image names, and nodepool functionality does not exist in any other plugin as far as I know (maybe fleet plugin has it, not sure). Because of this brand-new functionality, I'll approve it (otherwise we'd disallow this since plugin is a subset of other plugins).

But I'll recommend you to keep the plugin focused to fewer tasks and let other tools do each focused task better.

/hold cancel
/lgtm
/approve
Thanks!

Also, please consider setting up Krew release automation which helps you skip manually making updates to your Krew manifests on each new version and send a pull request. It’s a GitHub workflow bot that can run every time you push a new tag. Those PRs are automatically approved.

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 19, 2023
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 19, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahmetb, Kavinraja-G

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 19, 2023
@k8s-ci-robot k8s-ci-robot merged commit edc8678 into kubernetes-sigs:master Sep 19, 2023
1 check passed
@Kavinraja-G Kavinraja-G deleted the feat/add-nodegizmo branch September 19, 2023 05:30
@Kavinraja-G
Copy link
Contributor Author

Appreciate your detailed feedback about the plugin. Yup, I have more features in the pipeline that would be released in the upcoming weeks.

  • Custom nsenter images where users bring in their own debugging image or I'm planning to maintain custom set of debugging tools images which can be leveraged as well.
  • More sorting & filtering options in the node outputs
  • Node health information etc.,

Will keep this thread updated with new releases.

And, yes I had already integrated automation around creating PRs whenever I release a new plugin version.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/gray-area kind/new-plugin lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants