-
Notifications
You must be signed in to change notification settings - Fork 151
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sanitize GRPC logging #747
Sanitize GRPC logging #747
Conversation
Hi @tsmetana. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/ok-to-test |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mattcary, tsmetana The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
We originally added protosanitizer and removed it because we found it had signficant performance degradation. Our driver does not use secrets so I don't think we need it. #356 (comment) |
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
We should use the protosanitizer on the GRPC logs in order not to leak some sensitive data to the logs.
Special notes for your reviewer:
This PR adds dependency on protosanitizer from csi-lib-utils, hence the changes in vendor, go.mod, go.sum, etc.
Does this PR introduce a user-facing change?: