Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pre v0.4.0 release docs and staging image changes #229

Closed
wants to merge 1 commit into from
Closed

Pre v0.4.0 release docs and staging image changes #229

wants to merge 1 commit into from

Conversation

davidz627
Copy link
Contributor

/assign @msau42

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: davidz627

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Mar 9, 2019
@davidz627
Copy link
Contributor Author

The ordering I'm thinking of is this:

  1. Merge this PR which will make docs and staging images out of date temporarily (staging tests will begin to fail)
  2. Tag the commit as v0.4.0
  3. Release tooling will publish v0.4.0 staging images
  4. Monitor staging tests for success.
  5. On staging test success, push another change updating stable container images and cherry-pick to release branch v0.4.0

@k8s-ci-robot
Copy link
Contributor

@davidz627: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
pull-gcp-compute-persistent-disk-csi-driver-e2e 30f36a2 link /test pull-gcp-compute-persistent-disk-csi-driver-e2e

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@msau42
Copy link
Contributor

msau42 commented Mar 9, 2019

5. On staging test success, push another change updating stable container images and cherry-pick to release branch v0.4.0

Then would we have to tag a 0.4.1 that has the stable container image changes?

@davidz627
Copy link
Contributor Author

/hold
until rc tagged and soaked

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 9, 2019
@davidz627
Copy link
Contributor Author

/close
docs not ready

@k8s-ci-robot
Copy link
Contributor

@davidz627: Closed this PR.

In response to this:

/close
docs not ready

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@davidz627 davidz627 deleted the feature/v0.4release branch March 9, 2019 00:54
FZhg added a commit to FZhg/gcp-compute-persistent-disk-csi-driver that referenced this pull request Sep 20, 2023
@FZhg
Squashed 'release-tools/' changes from 78c0fb71..984feece
3b4f7c2 
984feece Merge pull request kubernetes-sigs#234 from siddhikhapare/csi-tools
1f7e6059 fixed broken links of testgrid dashboard
de2fba88 Merge pull request kubernetes-sigs#233 from andyzhangx/andyzhangx-patch-1
cee895e1 remove windows 20H2 build since it's EOL long time ago
670bb0ef Merge pull request kubernetes-sigs#229 from marosset/fix-codespell-errors
35d5e783 Merge pull request kubernetes-sigs#219 from yashsingh74/update-registry
63473cc9 Merge pull request kubernetes-sigs#231 from coulof/bump-go-version-1.20.5
29a5c76c Merge pull request kubernetes-sigs#228 from mowangdk/chore/adopt_kubernetes_recommand_labels
8dd28211 Update cloudbuild image with go 1.20.5
1df23dba Merge pull request kubernetes-sigs#230 from msau42/prow
1f92b7e7 Add ginkgo timeout to e2e tests to help catch any stuck tests
2b8b80ea fixing some codespell errors
c10b6780 Merge pull request kubernetes-sigs#227 from coulof/check-sidecar-supported-versions
72984ec0 chore: adopt kubernetes recommand label
b0555351 Header
bd0a10b6 typo
c39d73c3 Add comments
f6491af0 Script to verify EOL sidecar version
4133d1df Merge pull request kubernetes-sigs#226 from msau42/cloudbuild
8d519d23 Pin buildkit to v0.10.6 to workaround v0.11 bug with docker manifest
6e04a030 Merge pull request kubernetes-sigs#224 from msau42/cloudbuild
26fdfffd Update cloudbuild image
6613c398 Merge pull request kubernetes-sigs#223 from sunnylovestiramisu/update
0e7ae993 Update k8s image repo url
77e47cce Merge pull request kubernetes-sigs#222 from xinydev/fix-dep-version
155854b0 Fix dep version mismatch
8f839056 Merge pull request kubernetes-sigs#221 from sunnylovestiramisu/go-update
1d3f94dd Update go version to 1.20 to match k/k v1.27
e322ce5e Merge pull request kubernetes-sigs#220 from andyzhangx/fix-golint-error
b74a5120 test: fix golint error
901bcb5a Update registry k8s.gcr.io -> registry.k8s.io
aa61bfd0 Merge pull request kubernetes-sigs#218 from xing-yang/update_csi_driver
7563d196 Update CSI_PROW_DRIVER_VERSION to v1.11.0
a2171bef Merge pull request kubernetes-sigs#216 from msau42/process
cb987826 Merge pull request kubernetes-sigs#217 from msau42/owners
a11216e4 add new reviewers and remove inactive reviewers
dd986754 Add step for checking builds
b66c0824 Merge pull request kubernetes-sigs#214 from pohly/junit-fixes
b9b6763b filter-junit.go: fix loss of testcases when parsing Ginkgo v2 JUnit
d4277839 filter-junit.go: preserve system error log
38e11468 prow.sh: publish individual JUnit files as separate artifacts

git-subtree-dir: release-tools
git-subtree-split: 984feece4bafac3aad74deeed76a500a0c485fb1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jingxu97 jingxu97 Awaiting requested review from jingxu97

@saad-ali saad-ali Awaiting requested review from saad-ali

Assignees

@msau42 msau42

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@davidz627 @k8s-ci-robot @msau42