-
Notifications
You must be signed in to change notification settings - Fork 423
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐛 rbac: fix deduplication of core group and add test coverage #1045
🐛 rbac: fix deduplication of core group and add test coverage #1045
Conversation
5f660af
to
bc1929b
Compare
/test pull-controller-tools-test-master Dunno why it did not run |
@chrischdi: The specified target(s) for
Use In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/test pull-controller-tools-test-master |
@chrischdi: The specified target(s) for
Use In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
weird, why is there a |
bc1929b
to
4c27c10
Compare
Thank you very much!! /lgtm |
LGTM label has been added. Git tree hash: 73582574176256678d0b4379c9e391f5db1cfb43
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: chrischdi, sbueringer The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Fixes: #1036
Deduplication happened before renaming.
Now renaming before doing deduplication to fix this case for the core group.